The Wayback Machine - https://web.archive.org/web/20210715004700/https://github.com/nuxt/nuxt.js/pull/6719
Skip to content

/ nuxt.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): update code-of-conduct #6719

Merged
merged 4 commits into from Dec 4, 2019
Merged

chore(docs): update code-of-conduct #6719

merged 4 commits into from Dec 4, 2019

Conversation

@harrytran998
Copy link
Contributor

@harrytran998 harrytran998 commented Nov 23, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.
@harrytran998
chore(docs): Update CodeOfConduct vs ReleasePlan
f430e79
@harrytran998
Copy link
Contributor Author

@harrytran998 harrytran998 commented Nov 23, 2019

@clarkdo Pls check it!
@codecov-io
Copy link

@codecov-io codecov-io commented Nov 23, 2019 •
edited

Codecov Report

Merging #6719 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #6719   +/-   ##
=======================================
  Coverage   64.82%   64.82%           
=======================================
  Files          78       78           
  Lines        2718     2718           
  Branches      706      706           
=======================================
  Hits         1762     1762           
  Misses        729      729           
  Partials      227      227
Flag Coverage Δ
#unit 64.82% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e4e0f...1649e7f. Read the comment docs.
@clarkdo
clarkdo approved these changes Nov 23, 2019
View changes
@clarkdo clarkdo requested a review from Nov 23, 2019
@pimlie
Copy link
Contributor

@pimlie pimlie commented Nov 23, 2019

@jetaimefrc Why do you feel hatred against vuejs or nodejs? ;)
@harrytran998
Copy link
Contributor Author

@harrytran998 harrytran998 commented Nov 23, 2019 •
edited

@jetaimefrc Why do you feel hatred against vuejs or nodejs? ;)

LOL, I just kidding man! Actually, It's reverse 😂!
@harrytran998 harrytran998 mentioned this pull request Nov 23, 2019
Closed
7 tasks
@manniL
manniL reviewed Nov 23, 2019
View changes
RELEASE_PLAN.md Show resolved Hide resolved
clarkdo and others added 3 commits Nov 27, 2019
@clarkdo
Merge branch 'dev' into update-docs
5b56500
@clarkdo
Merge branch 'dev' into update-docs
12f9f31
@Atinux
Merge branch 'dev' into update-docs
1649e7f
@manniL
manniL approved these changes Dec 4, 2019
View changes
@kevinmarrec
kevinmarrec approved these changes Dec 4, 2019
View changes
@pi0 pi0 changed the title chore(docs): Update CodeOfConduct vs ReleasePlan chore(docs): update code-of-conduct Dec 4, 2019
@pi0 pi0 merged commit 53141cc into nuxt:dev Dec 4, 2019
10 checks passed
10 checks passed
@semantic-pull-requests
Semantic Pull Request ready to be squashed
Details
[ci.azure] nuxt.js #20191129.9 succeeded
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: lint-app Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-dev Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
@pi0 pi0 mentioned this pull request Dec 17, 2019
Merged
@snyk-bot snyk-bot mentioned this pull request Dec 25, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 27, 2020
Merged
This was referenced Mar 20, 2020
Merged
Open
@snyk-bot snyk-bot mentioned this pull request Mar 29, 2020
Merged
This was referenced Apr 8, 2020
Closed
Closed
Closed
Open
Merged
Open
This was referenced Apr 9, 2020
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0

@manniL manniL

@clarkdo clarkdo

@kevinmarrec kevinmarrec

Assignees

@harrytran998 harrytran998

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@harrytran998 @codecov-io @pimlie @manniL @clarkdo @pi0 @kevinmarrec @Atinux