Codecov Report

Merging #9328 (62b1bd7) into dev (e687842) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #9328   +/-   ##
=======================================
  Coverage   65.16%   65.16%           
=======================================
  Files          94       94           
  Lines        4105     4105           
  Branches     1124     1124           
=======================================
  Hits         2675     2675           
  Misses       1152     1152           
  Partials      278      278           

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e687842...62b1bd7. Read the comment docs.

Nice change

OOC, what will be broken when using node ?

@clarkdo cli dist (using dynamic imports) was getting broken

Is dynamic import not transpiled ?
I guess a version<12.20 will work ? But es2019 look better to me as well.

Is dynamic import not transpiled ?

Actually it transpiled to cjs by esbuild when using node while shouldn't (rollup is esm native and supports cjs with CommonJS plugin). Maybe we could use node if there was a node-es target...

Right, so node version >= 12.20 in target should work as it fully supports dynamic import.

OK, it seems not evanw/esbuild#1084 (comment)