I agree that the text message is most important. As far as colors, red is a universal (???) warning color. But red is also a common colorblind problem.

I like the FireFox color solution of using a red outline. Having a red background color would probably be too intense. I'd also question the logic of allowing themes to choose this color. To me it falls more in the realm of function rather than style. In any case having a text message is necessary.

It may be a separate issue but this is for searching in notes itself. What about the search in the note panel?

Hi @sif, I don't understand your comment. This issue is in regards to the in-note search box. The global search (as seen in your image) does not exhibit the same problem.

Hi,
I would like to work on this issue.

@nik-gautam Go ahead.

Hi,

So, I tried a few things. Can you please tell me if they look fine?

For Dark Theme:

For Light Theme:

@nik-gautam looks like you've got it! The only issue i can see is in your choice of background colour. The white text on a red background is difficult to read. You should use the dev tools to ensure that the contrast is sufficiently high.

@CalebJohn, I have a few doubts.

1> Is this color better?

2> The file NoteSearchBar is in JS now, so should I be converting to TypeScript before sending a pull request?

1> Is this color better?

Were you able to try just putting a red border on the text box instead of using a background change? Like in the firefox example above?

That way there is no readability issue and it could be the same for both light and dark themes.

@nik-gautam

1. Much better, please also confirm that the warning bar in Tools -> Options -> Encryption looks good with this colour (they share the theme colour if I remember correctly). You'll also need to confirm that this looks good using the themes that inherit from the dark theme (or change them if not)
2. Since this is such a small change, I would say no.

Were you able to try just putting a red border on the text box instead of using a background change? Like in the firefox example above?

It wouldn't hurt to look in to this, but users can often be resistant to change so I'm a bit hesitant to push this too far.

@CalebJohn and @thesunshade

so, I tried changing the border colour like the firefox example.

Here are the screenshots:-

• Light Theme w/ Border Color:-
  

• Light Theme w/ Background Color:-
  

• Dark Theme w/ Border Color:-
  

• Dark Theme w/ Background Color:-
  

Personally, I like the whole background colour red, as the input area is quite small and the larger area with red colour brings more attention.

Also, The encryption tab looks fine with the new warning color:-

I also found one more place where the warning colour was used:-

I tried to look for more places where this colour is used this is all I found. If I am missing some place, please remind me.

Also, can you tell me how to go about the localization for the "Phrase not found" string?

users can often be resistant to change so I'm a bit hesitant to push this too far.

Indeed they can!

Thanks @nik-gautam for your work on this!!

Thanks @nik-gautam for your work on this!!

It's my pleasure :)

@CalebJohn can you help out with this part? I am a bit confused about how to go about doing this.

Remember to localize the search task, please ask if you don't know how to do this

Sorry.

@nik-gautam please make a PR and we can continue the discusy there. At this point it's easier to talk about the code.