The Wayback Machine - https://web.archive.org/web/20201125092022/https://github.com/SheetJS/sheetjs/pull/1915
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix undefined range for writeFile - test with ods #1915

Open
wants to merge 1 commit into
base: master
from

Conversation

@jefleponot
Copy link

@jefleponot jefleponot commented Apr 23, 2020

fix undefined range for writeFile - test with ods as said in #1914

This FIX

function decode_range(range) { var x = (range||"A1A1").split(":").map(decode_cell); return {s:x[0],e:x[x.length-1]}; }

You are right correction doesn't fit LibreOffice behaviour. So I will propose another Fix :-)

LibreOffice Sheet with empty table : content.xml extract


<table:table table:name="test1_libreOffice" table:style-name="ta1">
    <table:table-column table:style-name="co1" table:default-cell-style-name="Default"/>
<table:table-row table:style-name="ro2">
<table:table-cell/>
</table:table-row>
</table:table>

LibreOffice Sheet with one element in table : content.xml extract


<table:table table:name="test2_libreOffice" table:style-name="ta1">
   <table:table-column table:style-name="co1" table:default-cell-style-name="ce1"/>
       <table:table-row table:style-name="ro1">
       <table:table-cell office:value-type="string" calcext:value-type="string">
           <text:p>merde</text:p>
       </table:table-cell>
    </table:table-row>
</table:table>

SheetJS writed file with my correction for an empty sheet :

    <table:table table:name="test1_sheetJS_ods">
        <table:table-row>
          <table:table-cell />
        </table:table-row>
      </table:table>

SheetJS writed file with my correction for an one cell sheet +1

<table:table table:name="test2_sheetJS_ods">
     <table:table-row>
          <table:table-cell />
         <table:table-cell office:value-type="string"><text:p>TOIP</text:p></table:table-cell>
          <table:covered-table-cell/>
          <table:table-cell />
    </table:table-row>
</table:table>

Do you agree to accept a New Pull Request ?

@SheetJSDev SheetJSDev force-pushed the SheetJS:master branch from 0786b99 to 3b589f0 Aug 12, 2020
@SheetJSDev SheetJSDev force-pushed the SheetJS:master branch from 4254ed4 to eec93b0 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.