The Wayback Machine - https://web.archive.org/web/20201125092021/https://github.com/SheetJS/sheetjs/pull/1916
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix_line_break_ods #1916

Open
wants to merge 2 commits into
base: master
from
Open

Conversation

@jefleponot
Copy link

@jefleponot jefleponot commented Apr 23, 2020

FIX libreOffice multi line cells #108

@SheetJSDev SheetJSDev requested a review from garrettluu Jul 7, 2020
@SheetJSDev
Copy link
Contributor

@SheetJSDev SheetJSDev commented Jul 7, 2020

Code-wise looks fine (not exactly rocket science), can you also update the bits/81_writeods.js file (https://github.com/SheetJS/sheetjs/blob/master/bits/81_writeods.js#L27) ?

Copy link
Contributor

@garrettluu garrettluu left a comment

Change looks good, but please add it to https://github.com/SheetJS/sheetjs/blob/master/bits/81_writeods.js#L27, since xlsx.js is actually generated by concatenating the files in the bits folder.

xlsx.js Show resolved Hide resolved
done
@SheetJSDev SheetJSDev force-pushed the SheetJS:master branch from 0786b99 to 3b589f0 Aug 12, 2020
LeSuisse added a commit to Enalean/tuleap that referenced this pull request Aug 18, 2020
This contribution does a serie of changes to make the resulting a bit
more usable when text field are exported:
* column width has been limited so we can avoid gigantic cell
* the row height is expanded to fit the multiple lines of the text if
  needed
* "\r\n" is replaced by "\n" to avoid the escaping of "\r" is the cell
  content

The bookSST [0] option has been enabled when creating the XSLX to avoid
issues with LibreOffice/OpenOffice [1].

Part of story #15096: export a report of tests for a milestone

[0] https://github.com/SheetJS/sheetjs/blob/v0.16.6/README.md#writing-options
[1] SheetJS/sheetjs#1916

Change-Id: Iac7215ca7dfe5fee52a0400d58d679fbe8948c99
@SheetJSDev SheetJSDev force-pushed the SheetJS:master branch from 4254ed4 to eec93b0 Oct 26, 2020
@nguyencongphu1998
Copy link

@nguyencongphu1998 nguyencongphu1998 commented Oct 30, 2020

Sorry, I still meet this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.