The Wayback Machine - https://web.archive.org/web/20240111120809/https://github.com/TheAlgorithms/Rust/pull/174
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tests for bubble sort to match standard #174

Merged
merged 2 commits into from Jan 24, 2021
Merged

Move tests for bubble sort to match standard #174

merged 2 commits into from Jan 24, 2021

Conversation

horahh
Copy link
Contributor

@horahh horahh commented Dec 8, 2020

  • Split test in two ascending and descending

@horahh
Copy link
Contributor Author

horahh commented Dec 8, 2020

can someone point me to where to look for the failure? I am not seeing any information about what the regression is? and in my machine cargo test is passing the 100 tests

@sandmor
Copy link

sandmor commented Dec 8, 2020

The command "cargo fmt --all -- --check" exited with 1.

The PR fails by the format not by the test, to fix it just run cargo fmt --all

AnshulMalik
AnshulMalik approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@AnshulMalik AnshulMalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnshulMalik AnshulMalik merged commit d490bfe into TheAlgorithms:master Jan 24, 2021
@AnshulMalik
Copy link
Member

Thanks @horahh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnshulMalik AnshulMalik AnshulMalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@horahh @sandmor @AnshulMalik