The Wayback Machine - https://web.archive.org/web/20210730081617/https://github.com/api-platform/api-platform/issues/1346
Skip to content

/ api-platform Template

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally remove google fonts dependency #1346

Open
jvigneron opened this issue Nov 28, 2019 · 7 comments
Open

Optionally remove google fonts dependency #1346

jvigneron opened this issue Nov 28, 2019 · 7 comments
Labels
good first issue

Comments

@jvigneron
Copy link

@jvigneron jvigneron commented Nov 28, 2019 •
edited

Description
Remove any google fonts dependency from api-platform.

Example
Remove the google font stylesheet in line 8 of api-platform\core\src\Bridge\Symfony\Bundle\Resources\views\SwaggerUi\index.html.twig depending on a configuration variable?

Context
I'm working on an intranet application for a big company where any call to the fonts.googleapi.com CDN takes 30 seconds to respond.
@dunglas
Copy link
Member

@dunglas dunglas commented Nov 28, 2019

Anyway I would like to remove the dependency Google's server. Maybe can we embed the font in the distribution? cc @ginifizz
@eerison eerison mentioned this issue Dec 28, 2019
Closed
@shivambhatia5432
Copy link

@shivambhatia5432 shivambhatia5432 commented Sep 30, 2020

Is this issue still open?
@dunglas
Copy link
Member

@dunglas dunglas commented Sep 30, 2020

Yes it is
@tripleee
Copy link

@tripleee tripleee commented Oct 2, 2020

This is prominently displayed on https://github.com/topics/hacktoberfest and the sloppy typing isn't exactly reflecting well on this project. Somebody with the privileges please edit the ticket into shape?
@jvigneron
Copy link
Author

@jvigneron jvigneron commented Oct 2, 2020

This is prominently displayed on https://github.com/topics/hacktoberfest and the sloppy typing isn't exactly reflecting well on this project. Somebody with the privileges please edit the ticket into shape?

Well, I tried to make it less 'sloppy' but the ticket seems to be cached on https://github.com/topics/hacktoberfest ...
@tripleee
Copy link

@tripleee tripleee commented Oct 2, 2020

"Optionaly" in the title is still misspelled. Thanks for fixing; I'm sure it will eventually be updated on the roster page too.
@jvigneron jvigneron changed the title Optionaly remove google fonts dependency Optionally remove google fonts dependency Oct 2, 2020
@rahil1304
Copy link

@rahil1304 rahil1304 commented Oct 3, 2020

Hey, I'd like to work on this issue if nobody has already taken it up?
@alanpoulain alanpoulain mentioned this issue Mar 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@dunglas @soyuka @tripleee @rahil1304 @shivambhatia5432 @jvigneron