The Wayback Machine - https://web.archive.org/web/20201231025747/https://github.com/sinatra/sinatra/issues/1249
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2.0 README translations #1249

Open
burningTyger opened this issue Feb 1, 2017 · 30 comments
Open

Update 2.0 README translations #1249

burningTyger opened this issue Feb 1, 2017 · 30 comments

Comments

@burningTyger
Copy link
Member

@burningTyger burningTyger commented Feb 1, 2017

The Readme is our comprehensive sinatra documentation and deserves a lot of love. Thank you for everybody who has contributed to it so far!

The translations are great but some of them seem incomplete or outdated. For sinatra 2.0 they need a major overhaul and here's a list of languages that need to be worked on:

  • German
  • Spanish
  • French
  • Hungarian
  • Portuguese (Brasil/Portugal)
  • Korean
  • Russian
  • Chinese
@burningTyger burningTyger changed the title Update README translations Update 2.0 README translations Feb 1, 2017
@zzak zzak added the docs label Mar 4, 2017
@zzak
Copy link
Member

@zzak zzak commented Mar 4, 2017

Here are all the commits on README, most everything since the last release fits on one page:
https://github.com/sinatra/sinatra/commits/master/README.md

@romasks
Copy link
Contributor

@romasks romasks commented Jun 28, 2017

Hi. I'd like to update Russian translation of 2.0 README.

@romasks
Copy link
Contributor

@romasks romasks commented Jun 29, 2017

There is a phrase in section Literal Templates: "if there is a filesystem path or line associated with that string". Maybe and will be more suitable in this context?

@Ice-Storm
Copy link
Contributor

@Ice-Storm Ice-Storm commented Jul 11, 2017

Hi. I'd like to update Chinese translation of 2.0 README.
PR #1323

@CharlyJazz
Copy link
Contributor

@CharlyJazz CharlyJazz commented Dec 9, 2017

I am currently working on the Spanish translation. 👷‍♂️

@namusyaka namusyaka added this to the Beyond milestone Feb 19, 2018
nbulaj added a commit to nbulaj/sinatra that referenced this issue Feb 20, 2018
Update README.ru.md to actual version of English README.
Fix small punctuation and stylistic issues.
@nbulaj
Copy link
Contributor

@nbulaj nbulaj commented Feb 20, 2018

Check out #1393 with up-to-date RU translation.

@raphaeltelatim
Copy link

@raphaeltelatim raphaeltelatim commented Feb 28, 2018

@burningTyger Do you still need pt-BR translation for 2.0 README?

@burningTyger
Copy link
Member Author

@burningTyger burningTyger commented Mar 1, 2018

@raphaeltelatim Sorry, my Portuguese is not good enough to tell if it's up to date :) But if it needs new docs we're happy to merge them! Thank you for your efforts.

@Klockner
Copy link

@Klockner Klockner commented Nov 1, 2018

@burningTyger I've checked the pt-BR translation from README and realized that it is outdated, can I work on it? =)

@burningTyger
Copy link
Member Author

@burningTyger burningTyger commented Nov 1, 2018

@Klockner sure, that would be great. 👍

@Klockner
Copy link

@Klockner Klockner commented Nov 10, 2018

@burningTyger It is my first contribution. So I will start with this little one (#1497) to take the way and keep moving forward. Should I use this same PR for all the changes that will come or should I do it in separated parts?
Any advice would be welcome, thanks. 👍

@burningTyger
Copy link
Member Author

@burningTyger burningTyger commented Nov 11, 2018

@Klockner this looks good so far. I suggest you translate the explanations around the code samples which you already did along with the different configuration settings and then sqash them into one commit so it looks nice. If all you edit is the md file you can add a [ci skip] to your commit message so the tests are not run on it. If you manage to translate even more that would also be very nice. Do you know someone who could look over your translation? My Portuguese is really poor.

One more thing I noticed. Could you try to keep each line with 80 characters or less? ie. make a line break before 80 characters? I know, it's a relic from the past but I found it quite useful later on when comparing line changes.

@Klockner
Copy link

@Klockner Klockner commented Nov 14, 2018

@burningTyger I got someone pt-br native to do the review. I have also applied your suggestions on it.
What are the next steps?

@christopherganda
Copy link

@christopherganda christopherganda commented Dec 20, 2018

I would like to add indonesian translation, is there any requirements I need to understand?

@burningTyger
Copy link
Member Author

@burningTyger burningTyger commented Dec 20, 2018

@christopherganda first of all welcome to sinatra! If you would like to translate feel free just start with the basics. The documentation is quite comprehensive and even a subset is a great start. It helps if you have someone you can work with and who can proof read your translations. I will be checking your translation afterwards for style errors and the like.

@christopherganda
Copy link

@christopherganda christopherganda commented Dec 20, 2018

@burningTyger Cool! Working on it

@jeduardo824
Copy link
Contributor

@jeduardo824 jeduardo824 commented May 27, 2019

I noticed that pt-br translation needs some updates. @Klockner are you working on this? I can start to work on those updates if you stopped to translate :)

@Klockner
Copy link

@Klockner Klockner commented May 27, 2019

@jeduardo824 sounds great for me, if it's ok for @burningTyger go ahead! I can also do the pt-br review for you =)

We already have this WIP PR:
#1497

@burningTyger
Copy link
Member Author

@burningTyger burningTyger commented May 28, 2019

sure, just go ahead.

@ghost
Copy link

@ghost ghost commented Jul 7, 2019

Anyone need help with the Brazilian Portuguese ?

@ghost
Copy link

@ghost ghost commented Jul 18, 2019

Is the topic still valid ?

@jeduardo824
Copy link
Contributor

@jeduardo824 jeduardo824 commented Jul 18, 2019

@PedroPaulino I updated Brazillian Portuguese translation. Waiting for the merge.

@burningTyger
Copy link
Member Author

@burningTyger burningTyger commented Jul 20, 2019

I've had a very quick glance at it. Please fix the following parts:
-[Definindo Corpo, Código de Status e Cabeçalhos] (#definindo-corpo-codigo-de-status-cabeçalhos) -> space

  • Configurações Disponíveis has a messed up markup, parts of it show up in monospaced font
  • there is something wrong at the very bottom of the file
@camillesk
Copy link

@camillesk camillesk commented Oct 1, 2019

the issue still valid to new translations?

@burningTyger
Copy link
Member Author

@burningTyger burningTyger commented Oct 2, 2019

Sure, but it would be good if someone took this over from me.

@pabuisson
Copy link
Contributor

@pabuisson pabuisson commented Oct 6, 2019

I can give a go at updating the French readme, looks like it's not been updated for 6 months.

@pabuisson
Copy link
Contributor

@pabuisson pabuisson commented Oct 6, 2019

Got a PR for updates on the French readme : #1568

I might make a separate PR someday for the "sessions" section where a lot of new content is missing. But don't have enough time for it right now.

@camillesk
Copy link

@camillesk camillesk commented Oct 25, 2019

My PR for pt-br translations is here: #1573

Soon I'll update the other half of the file

@jeduardo824
Copy link
Contributor

@jeduardo824 jeduardo824 commented Oct 25, 2019

I already have a PR with an updated PT-BR translation @camillesk #1540

@jkowens jkowens reopened this Oct 25, 2019
@pabuisson
Copy link
Contributor

@pabuisson pabuisson commented Feb 4, 2020

Hey guys 👋 I was wondering what would be the best way to act on those documentation PRs and have them merged? They would improve locale documentation for the whole Sinatra project, seems it'd be a shame to let them die.

Any maintainer in particular we should ping about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

You can’t perform that action at this time.