The Wayback Machine - https://web.archive.org/web/20201125151016/https://github.com/pterodactyl/panel/issues/2520
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CPU usage display like memory usage #2520

Open
R3TROATTACK opened this issue Oct 14, 2020 · 13 comments
Open

Make CPU usage display like memory usage #2520

R3TROATTACK opened this issue Oct 14, 2020 · 13 comments

Comments

@R3TROATTACK
Copy link

@R3TROATTACK R3TROATTACK commented Oct 14, 2020

Is your feature request related to a problem? Please describe.
The CPU usage graph doesn't accurately represent how much CPU usage you are actually using at a glance and can be quite confusing.

Describe the solution you'd like
I would like for the CPU usage graph to be displayed the same way memory usage is displayed ie instead of 0-+1 of current CPU usage make it 0-100 always and draw the graph normally.

Describe alternatives you've considered
The other alternative is leaving as it currently is.

Additional context
image

@AreYouRlyScared
Copy link
Contributor

@AreYouRlyScared AreYouRlyScared commented Oct 14, 2020

Not sure how that's confusing as its showing you what that specific server is using? Which seems to be about 3%

@matthewpi
Copy link
Member

@matthewpi matthewpi commented Oct 14, 2020

The only thing I could see doing is making the CPU graph's max value on the y-axis be the server's CPU Limit instead of being a smaller value. So for example, if your server has a CPU limit of 100%, the graph's y-axis will have a maximum of 100% and a minimum of 0%.

Other than that I don't see how anything else could improve it.

@R3TROATTACK
Copy link
Author

@R3TROATTACK R3TROATTACK commented Oct 14, 2020

The only thing I could see doing is making the CPU graph's max value on the y-axis be the server's CPU Limit instead of being a smaller value. So for example, if your server has a CPU limit of 100%, the graph's y-axis will have a maximum of 100% and a minimum of 0%.

Other than that I don't see how anything else could improve it.

I might've just worded this badly but this is what I meant. Since I was more talking about viewing it at a glance and not getting a reference of where it is at. Like I understand how it works and this might just be more of how I use the CPU graph and wanting the two graphs to work the same.

@DaneEveritt
Copy link
Member

@DaneEveritt DaneEveritt commented Oct 14, 2020

What happens when the limit is 400% and you're only using 20%? It would be next to impossible to see any changes in it. Although I suppose it is the same for memory and this is a moot point.

edit: What about when there is no limit, what is the cap in that scenario?

@R3TROATTACK
Copy link
Author

@R3TROATTACK R3TROATTACK commented Oct 14, 2020

What happens when the limit is 400% and you're only using 20%? It would be next to impossible to see any changes in it. Although I suppose it is the same for memory and this is a moot point.

edit: What about when there is no limit, what is the cap in that scenario?

Wouldn't the cap be the what ever the cap of the CPU or does it not work that way?

@matthewpi
Copy link
Member

@matthewpi matthewpi commented Oct 14, 2020

What happens when the limit is 400% and you're only using 20%? It would be next to impossible to see any changes in it. Although I suppose it is the same for memory and this is a moot point.
edit: What about when there is no limit, what is the cap in that scenario?

Wouldn't the cap be the what ever the cap of the CPU or does it not work that way?

Servers can have an "unlimited" CPU limit if it is set to 0.

@R3TROATTACK
Copy link
Author

@R3TROATTACK R3TROATTACK commented Oct 14, 2020

I guess you figure out the max and display that as the CPU max ie 8 core would be 800% while a 4 core would be 400% I'm also starting to see why the CPU graph is designed the way it is.

Another option would be to display a new graph for every 100% since if I read the documentation correctly its core count * 100 per core and anything less that 100 would be just a percentage of 1 core. This way also would be useful for the CPU Pinning setting to display how much of that core is being used.

@Shinrai
Copy link

@Shinrai Shinrai commented Oct 18, 2020

Personally I’d like to see a scale from 0-100% regardless of how many cores are assigned to the server. Graphs are supposed to be easy references. Having to do math (even as simple as it is) doesn’t give me the info at a glance I want.

@AreYouRlyScared
Copy link
Contributor

@AreYouRlyScared AreYouRlyScared commented Oct 18, 2020

0-100 wouldn't make sense, as linux each thread is 100%, so a 4 thread server will have usage of 400% if it's using everything.

@tinyoverflow
Copy link

@tinyoverflow tinyoverflow commented Oct 19, 2020

I see the following options, ordered by how much I like these solutions:

  1. Set the default cap to 100%, scale up by 100% if it exceeds it. (10% cpu => 100% graph, 120% cpu => 200% graph)
  2. Set min=0 and max=cpu_limit from build configuration, otherwise leave it as is.
  3. Leave it as is, as it definitely is possible to get used to it.
  4. Same as above but cap to 100%.

I would like to see your opinions about that.
1: 🎉 2: ❤️ 3: 🚀 4: 👀

@DaneEveritt
Copy link
Member

@DaneEveritt DaneEveritt commented Oct 19, 2020

We used to calculate everything as a scale of 100%, and a lot of people disliked it and found it incredibly confusing.

To me, the two options are:

1.) Leave it how it is.
2.) Use the maximum CPU limit as the graph cap. (e.g. 100/200/800) and if no limit is assigned just make it increments of 100 so it isn't as dramatic when things change.

@tinyoverflow
Copy link

@tinyoverflow tinyoverflow commented Oct 19, 2020

With these two options available, I would definitely go with number two.

@R3TROATTACK
Copy link
Author

@R3TROATTACK R3TROATTACK commented Oct 19, 2020

I definitely think the 2nd option would be a lot more user friendly, but as others have mentioned you get use to it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.