The Wayback Machine - https://web.archive.org/web/20210816111716/https://github.com/kubernetes/minikube/issues/11571
Skip to content

/ minikube

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add detailed info about what each integration test is doing to the site #11571

Open
medyagh opened this issue Jun 3, 2021 · 4 comments
Open

add detailed info about what each integration test is doing to the site #11571

medyagh opened this issue Jun 3, 2021 · 4 comments
Assignees
@KShivendu
Labels
area/testing good first issue kind/documentation priority/important-longterm

Comments

@medyagh
Copy link
Member

@medyagh medyagh commented Jun 3, 2021 •
edited

currently our make generate-docs creates this page

https://minikube.sigs.k8s.io/docs/contrib/tests/

which generates the site based on the Comments on the Test and validate the func,

I would like these descriptions to exaclty say what it is doing instead of a general text 

validateBuildImage 
makes sures that minikube image build works as expected

it should say

validateBuildImage makes sures that `minikube image build` works as expected
 builds an image using `minikube image build` and 
 the Dockerfile located in test/integration/testdata/build/Dockerfile 
 which adds a relative file into a busybox container
 and then ensures the image was build using image inspect inside minikbue 
 special case :
 in case of contained it starts the buildkit inside minikube
 currently skipped on None Driver and Github Actions on MacOs,
@dinever
Copy link
Contributor

@dinever dinever commented Jun 3, 2021

/assign
@dinever dinever mentioned this issue Jun 7, 2021
Open
@jayesh-srivastava
Copy link

@jayesh-srivastava jayesh-srivastava commented Jul 21, 2021

Hey, I am a beginner and I would like to work on this issue. Can you please explain a bit further and assign it to me. That would be great.
@KShivendu
Copy link

@KShivendu KShivendu commented Jul 30, 2021

/assign
@k8s-ci-robot k8s-ci-robot assigned KShivendu and unassigned dinever Jul 30, 2021
@KShivendu
Copy link

@KShivendu KShivendu commented Jul 30, 2021

Hi @dinever It has been a while since you commented on the task. If you're busy, can you please assign the task to me?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KShivendu KShivendu

Labels
area/testing good first issue kind/documentation priority/important-longterm
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@dinever @medyagh @sharifelgamal @KShivendu @jayesh-srivastava