The Wayback Machine - https://web.archive.org/web/20210816111705/https://github.com/kubernetes/minikube/issues/12027
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report crun version in minikube version #12027

Open
andriyDev opened this issue Jul 20, 2021 · 9 comments
Open

Report crun version in minikube version #12027

andriyDev opened this issue Jul 20, 2021 · 9 comments

Comments

@andriyDev
Copy link
Collaborator

@andriyDev andriyDev commented Jul 20, 2021

@amino19
Copy link

@amino19 amino19 commented Jul 21, 2021

@andriyDev : Important location link is not working..? 🤔

@andriyDev
Copy link
Collaborator Author

@andriyDev andriyDev commented Jul 21, 2021

@amino19 Woops! I guess my link extension doesn't work haha, fixed!

@jayesh-srivastava
Copy link

@jayesh-srivastava jayesh-srivastava commented Jul 24, 2021

Hi. Is this issue open? Can I work on it?

@amino19
Copy link

@amino19 amino19 commented Jul 24, 2021

Hi. Is this issue open? Can I work on it?

@jayesh-srivastava : Hi, Thanks for showing interest.
Pl go through the links, mentioned by @andriyDev, & ones you feel comfortable to get started with, give a shot with PR, after self-assigning yourself, by typing /assign 🙂

@jayesh-srivastava
Copy link

@jayesh-srivastava jayesh-srivastava commented Jul 24, 2021

Okay sure. Thank you so much. I am a new contributor here but will try to work on this.

@jayesh-srivastava
Copy link

@jayesh-srivastava jayesh-srivastava commented Jul 24, 2021

/assign

@jayesh-srivastava
Copy link

@jayesh-srivastava jayesh-srivastava commented Jul 24, 2021

Hi @amino19 , I have somewhat understood what needs to be done, basically, I'll have to add crun in the list. Just wanted to ask that what will be its value and is that all that I have to do. Your help will be much appreciated : )

@spowelljr
Copy link
Collaborator

@spowelljr spowelljr commented Jul 30, 2021

@jayesh-srivastava crun --version gets you the version for crun. The only other thing that needs to be done is update the test to ensure it's actually being output.

https://github.com/kubernetes/minikube/blob/master/test/integration/functional_test.go#L1983

@afbjorklund
Copy link
Collaborator

@afbjorklund afbjorklund commented Aug 4, 2021

Note that crun --version also output some extra junk (beyond version), but fixed in PR #12085

$ crun --version
crun version 0.20.1.5-925d-dirty
commit: 0d42f1109fd73548f44b01b3e84d04a279e99d2e
spec: 1.0.0
+SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +CRIU +YAJL

The "dirty" thing is some kind of upstream packaging bug, modifying the source before building...

https://build.opensuse.org/package/show/devel:kubic:libcontainers:stable/crun

EDIT: Actually it is showing the commit of the packaging repository: https://gitlab.com/rhcontainerbot/crun

https://gitlab.com/rhcontainerbot/crun/-/commit/925db482ab20e0effd1fdaef1cfb5002019a9b5f (5 commits ahead)

The "commit" shown (for 0.20.1) is from the previous software version (crun 0.20): containers/crun@0d42f11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants