Report crun version in minikube version
#12027
Comments
@andriyDev : Important location link is not working..? |
@amino19 Woops! I guess my link extension doesn't work haha, fixed! |
Hi. Is this issue open? Can I work on it? |
@jayesh-srivastava : Hi, Thanks for showing interest. |
Okay sure. Thank you so much. I am a new contributor here but will try to work on this. |
/assign |
Hi @amino19 , I have somewhat understood what needs to be done, basically, I'll have to add crun in the list. Just wanted to ask that what will be its value and is that all that I have to do. Your help will be much appreciated : ) |
@jayesh-srivastava https://github.com/kubernetes/minikube/blob/master/test/integration/functional_test.go#L1983 |
Note that
The "dirty" thing is some kind of upstream packaging bug, modifying the source before building... https://build.opensuse.org/package/show/devel:kubic:libcontainers:stable/crun EDIT: Actually it is showing the commit of the packaging repository: https://gitlab.com/rhcontainerbot/crun https://gitlab.com/rhcontainerbot/crun/-/commit/925db482ab20e0effd1fdaef1cfb5002019a9b5f (5 commits ahead) The "commit" shown (for 0.20.1) is from the previous software version (crun 0.20): containers/crun@0d42f11 |
Important location: https://github.com/kubernetes/minikube/blob/master/cmd/minikube/cmd/version.go#L55
Discussion: https://kubernetes.slack.com/archives/C1F5CT6Q1/p1626820802044000?thread_ts=1626811554.016000&cid=C1F5CT6Q1
The text was updated successfully, but these errors were encountered: