The Wayback Machine - https://web.archive.org/web/20210830052637/https://github.com/jina-ai/jina/issues/3024
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete-all interface to JinaDClient #3024

Open
deepankarm opened this issue Jul 28, 2021 · 10 comments
Open

Add delete-all interface to JinaDClient #3024

deepankarm opened this issue Jul 28, 2021 · 10 comments

Comments

@deepankarm
Copy link
Member

@deepankarm deepankarm commented Jul 28, 2021

Describe the feature
Implement client methods for the following endpoints:

  • DELETE /workspaces
  • DELETE /flows
  • DELETE /pods
  • DELETE /peas
@AnudeepGunukula
Copy link

@AnudeepGunukula AnudeepGunukula commented Jul 30, 2021

Hi i am interested in this project, i would like to work on this issue.

@deepankarm
Copy link
Member Author

@deepankarm deepankarm commented Jul 30, 2021

@AnudeepGunukula awesome. Looking forward to a PR :)

@AnudeepGunukula
Copy link

@AnudeepGunukula AnudeepGunukula commented Aug 2, 2021

Hi, please let me know what is the location of the jinadclient module
and where should i start working from ?

@deepankarm
Copy link
Member Author

@deepankarm deepankarm commented Aug 4, 2021

@AnudeepGunukula Here's the JinaDClient module. Please add a clear method to base.py that should sent a DELETE request to self.store_api. Don't forget to add tests for the same.

@AnudeepGunukula
Copy link

@AnudeepGunukula AnudeepGunukula commented Aug 4, 2021

Thankyou, for the details, i will start working on it and try to implement the methods.

@deepankarm
Copy link
Member Author

@deepankarm deepankarm commented Aug 4, 2021

I've assigned the issue to you. Looking forward to a PR :)

@AnudeepGunukula
Copy link

@AnudeepGunukula AnudeepGunukula commented Aug 5, 2021

clear
Hi deepankarm, i have just implemented sample method, which makes a delete call to api
kindly let me know, what i need to add more to function.
so that i can work on that

@deepankarm
Copy link
Member Author

@deepankarm deepankarm commented Aug 6, 2021

@AnudeepGunukula
Copy link

@AnudeepGunukula AnudeepGunukula commented Aug 6, 2021

Hi, deepankarm. I had made a pr, please let me know the modifications.
so that i can work on that and make new commits to the pr.

@nan-wang nan-wang linked a pull request that will close this issue Aug 7, 2021
@AnudeepGunukula
Copy link

@AnudeepGunukula AnudeepGunukula commented Aug 10, 2021

Hi @deepankarm, i had made a new pr with the both clear and test method.
i had closed the old pr with wrong commit message.
The new pr is #3142 , kindly let me know the modifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants