The Wayback Machine - https://web.archive.org/web/20211215041509/https://github.com/desktop/desktop/issues/9831
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows Terminal Preview #9831

Open
Studio384 opened this issue May 20, 2020 · 8 comments
Open

Add Windows Terminal Preview #9831

Studio384 opened this issue May 20, 2020 · 8 comments

Comments

@Studio384
Copy link

@Studio384 Studio384 commented May 20, 2020

Describe the feature or problem you’d like to solve

Microsoft released Windows Terminal Preview yesterday. It would be nice if GitHub Desktop was able to detect it.

Proposed solution

Adds an option to the shells available to use.

Additional context

N/A

@rafeca
Copy link
Contributor

@rafeca rafeca commented May 20, 2020

Hey @Studio384! Thanks for this suggestion.

Windows Terminal support was added a few versions ago (see #9047). You can configure the preferred terminal app from the Integrations pane on the settings modal.

I have just upgraded my local installation of Windows Terminal to v1.0 and Desktop keeps detecting it correctly.

I'm going to close this issue, but please feel free to reopen with repro steps if for some reason you can't manage to get it working.

Loading

@rafeca rafeca closed this May 20, 2020
@Studio384
Copy link
Author

@Studio384 Studio384 commented May 20, 2020

Windows Terminal != Windows Terminal Preview

Terminal Preview is the beta release channel for Windows Terminal. It cannot be detected by Desktop right now.

Loading

@rafeca
Copy link
Contributor

@rafeca rafeca commented May 20, 2020

Thanks for the clarification @Studio384 !

You're right then, I think support to it can easily be added by following the same approach we use for Windows Terminal (source). Would you be open to contribute on this?

Loading

@Studio384
Copy link
Author

@Studio384 Studio384 commented May 20, 2020

I've never done it before, but will give it a try.

Loading

@say25
Copy link
Member

@say25 say25 commented Aug 13, 2020

So this sorta isn't required. Basically trying to debug myself microsoft/terminal#7188 it would appear that both Windows Terminal and Window Terminal Preview share wt.exe. Basically you could uninstall Windows Terminal and only leave Window Terminal Preview and the existing integration would open Windows Terminal Preview.

I believe effectively the Windows Terminal would need to expose a different Exe or hook to differentiate between the two.

Loading

@nearlySplat
Copy link

@nearlySplat nearlySplat commented Sep 18, 2020

Ermmm... I'm not that good with this kinda stuff, but maybe you could check for the wt.exe inside a containing folder?

Like checking for a sampleFolder\executable.exe instead of just executable.exe

Because obviously Microsoft doesn't overwrite the wt.exe of the Windows Terminal that's not a Preview.

Loading

@AndreiMaga
Copy link
Contributor

@AndreiMaga AndreiMaga commented Dec 1, 2020

As far as I know of how wt and wtp work, they both use the same executable to run, which is exposed at C:\Users\<User>\AppData\Local\Microsoft\WindowsApps\wt.exe. And you can choose the one you want to actually run by changing the alias of the wt.exe from inside the App execution aliases ( source of information ). So the desired behavior can be obtained from Windows itself so desktop won't have to add support for a beta version of something it already has. TL:DR, Desktop already supports Windows Terminal Preview, you just have to turn it on from a windows setting.

Loading

@just1a-person
Copy link

@just1a-person just1a-person commented Dec 23, 2020

@AndreiMaga You are correct! GitHub Desktop already supports Windows Terminal Preview. You have to choose in the app execution aliases setting (in Windows Settings)

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants