New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows Terminal Preview #9831
Comments
Hey @Studio384! Thanks for this suggestion. Windows Terminal support was added a few versions ago (see #9047). You can configure the preferred terminal app from the Integrations pane on the settings modal. I have just upgraded my local installation of Windows Terminal to v1.0 and Desktop keeps detecting it correctly. I'm going to close this issue, but please feel free to reopen with repro steps if for some reason you can't manage to get it working. |
Windows Terminal != Windows Terminal Preview Terminal Preview is the beta release channel for Windows Terminal. It cannot be detected by Desktop right now. |
Thanks for the clarification @Studio384 ! You're right then, I think support to it can easily be added by following the same approach we use for Windows Terminal (source). Would you be open to contribute on this? |
I've never done it before, but will give it a try. |
So this sorta isn't required. Basically trying to debug myself microsoft/terminal#7188 it would appear that both Windows Terminal and Window Terminal Preview share I believe effectively the Windows Terminal would need to expose a different Exe or hook to differentiate between the two. |
Ermmm... I'm not that good with this kinda stuff, but maybe you could check for the Like checking for a Because obviously Microsoft doesn't overwrite the |
As far as I know of how wt and wtp work, they both use the same executable to run, which is exposed at |
@AndreiMaga You are correct! GitHub Desktop already supports Windows Terminal Preview. You have to choose in the app execution aliases setting (in Windows Settings) |
Describe the feature or problem you’d like to solve
Microsoft released Windows Terminal Preview yesterday. It would be nice if GitHub Desktop was able to detect it.
Proposed solution
Adds an option to the shells available to use.
Additional context
N/A
The text was updated successfully, but these errors were encountered: