internal: use util.types to migrate DEP0103 in Node.js #3704

joyeecheung · 2018-03-23T13:51:49Z

Use require('util').types instead of using process.binding('util')
to get the type checking helpers
Rename nodeUtil to nodeTypes since that is what it is for

Here is what I used to test this script:

arr.js

import isArrayBuffer from './isArrayBuffer.js'
import isDate from './isDate.js'
import isMap from './isMap.js'
import isRegExp from './isRegExp.js'
import isSet from './isSet.js'
import isTypedArray from './isTypedArray.js'

const arr = [
  isArrayBuffer(new Uint8Array().buffer),
  isDate(new Date()),
  isMap(new Map()),
  isRegExp(/test/),
  isSet(new Set()),
  isTypedArray(new Uint8Array())
]

export default arr

test.js

'use strict';
const a = require('./bundle');
console.log(a);

wget https://nodejs.org/download/nightly/v10.0.0-nightly20180322e714da6f0a/node-v10.0.0-nightly20180322e714da6f0a-darwin-x64.tar.xz
tar xf node-v10.0.0-nightly20180322e714da6f0a-darwin-x64.tar.xz

git checkout master
rollup arr.js --output.format cjs --output.file bundle.js
node-v10.0.0-nightly20180322e714da6f0a-darwin-x64/bin/node --pending-deprecation --trace-warnings test.js
# [ true, true, true, true, true, true ]
# [DEP0103] DeprecationWarning: Accessing native typechecking bindings of Node directly is deprecated. Please use `util.types.isArrayBuffer` instead.

git checkout node-dep-0103
rollup arr.js --output.format cjs --output.file bundle.js
node-v10.0.0-nightly20180322e714da6f0a-darwin-x64/bin/node --pending-deprecation --trace-warnings test.js
# [ true, true, true, true, true, true ]
# no warnings

- Use require('util').types instead of using process.binding('util') to get the type checking helpers - Rename nodeUtil to nodeTypes since that is what it is for Refs: nodejs/node#18415

jsf-clabot · 2018-03-23T13:51:50Z

All committers have signed the CLA.

jdalton · 2018-03-23T14:31:46Z

Thanks @joyeecheung!

I'll backport this for Lodash v4 so the 30,000+ packages that depend on it will get the update too.

lock · 2019-03-23T15:57:58Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

jdalton added the enhancement label Mar 23, 2018

jdalton merged commit 363fef0 into lodash:master Mar 23, 2018
2 checks passed

2 checks passed

Node Security No known vulnerabilities found
Details

licence/cla Contributor License Agreement is signed.
Details

joyeecheung mentioned this pull request Mar 23, 2018

meta: state of deprecations nodejs/node#19561

Closed

lock bot locked as resolved and limited conversation to collaborators Mar 23, 2019

Nov	DEC	Jun
	20
2019	2020	2022

lodash / lodash

internal: use util.types to migrate DEP0103 in Node.js #3704

internal: use util.types to migrate DEP0103 in Node.js #3704

joyeecheung commented Mar 23, 2018 •

edited

jsf-clabot commented Mar 23, 2018 •

edited

jdalton commented Mar 23, 2018 •

edited

lock bot commented Mar 23, 2019

lodash / lodash

internal: use util.types to migrate DEP0103 in Node.js #3704

internal: use util.types to migrate DEP0103 in Node.js #3704

Conversation

joyeecheung commented Mar 23, 2018 • edited

jsf-clabot commented Mar 23, 2018 • edited

jdalton commented Mar 23, 2018 • edited

lock bot commented Mar 23, 2019

joyeecheung commented Mar 23, 2018 •

edited

jsf-clabot commented Mar 23, 2018 •

edited

jdalton commented Mar 23, 2018 •

edited