Coerce indexOf fromIndex parameter to integer using toInteger #4410
Conversation
|
Here is a test case from v4 covering this issue: https://github.com/lodash/lodash/blob/4.17.5-post/test/test.js#L6247 |
|
Thank you again and again @blikblum! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Uses toInteger instead of plus sign to coerce fromIndex parameter in indexOf.
This fixes use cases like
indexOf([1, 2, 1, 2], 2, 2.1)