The Wayback Machine - https://web.archive.org/web/20210829031301/https://github.com/PowerShell/PowerShell/pull/15897
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC 277: native error throwing #15897

Merged
merged 47 commits into from Aug 24, 2021

Conversation

@rjmholt
Copy link
Member

@rjmholt rjmholt commented Aug 9, 2021

PR Summary

Continuation of @rkeithhill's work in #15757.

Implements error throwing with error action preference integration for native executables, similar to set -e scenarios on *nix.

PR Context

See on PowerShell/PowerShell-RFC#277.

PR Checklist

@rjmholt rjmholt requested a review from daxian-dbw Aug 23, 2021
@rjmholt rjmholt requested a review from daxian-dbw Aug 24, 2021
continue
}

$hitTrap = $false

This comment has been minimized.

@iSazonov

iSazonov Aug 24, 2021
Collaborator

Should we explicitly create $exception in the scope too?

This comment has been minimized.

@rjmholt

rjmholt Aug 24, 2021
Author Member

Well it'll be $null by default, rather than $false, so we don't really need to

@daxian-dbw daxian-dbw merged commit a4d1457 into PowerShell:master Aug 24, 2021
34 checks passed
34 checks passed
@github-actions
Analyze (csharp)
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
CodeFactor 19 issues fixed. 8 issues found.
Details
PowerShell-CI-SSH #PR-15897-20210824.03 succeeded
Details
@azure-pipelines
PowerShell-CI-linux Build #PR-15897-20210824.03 succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Build for Linux linux Build) Build for Linux linux Build succeeded
Details
@azure-pipelines
PowerShell-CI-linux (CodeCoverage and Test Packages CodeCoverage and Test Packages) CodeCoverage and Test Packages CodeCoverage and Test Packages succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Package Linux Linux packaging) Package Linux Linux packaging succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Test for Linux Linux Test - ElevatedPesterTests - CI) Test for Linux Linux Test - ElevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Test for Linux Linux Test - ElevatedPesterTests - Others) Test for Linux Linux Test - ElevatedPesterTests - Others succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Test for Linux Linux Test - UnelevatedPesterTests - CI) Test for Linux Linux Test - UnelevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Test for Linux Linux Test - UnelevatedPesterTests - Others) Test for Linux Linux Test - UnelevatedPesterTests - Others succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Test for Linux Verify xUnit Results) Test for Linux Verify xUnit Results succeeded
Details
@azure-pipelines
PowerShell-CI-macos Build #PR-15897-20210824.03 succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Build for macOS macOS Build) Build for macOS macOS Build succeeded
Details
@azure-pipelines
PowerShell-CI-macos (CodeCoverage and Test Packages CodeCoverage and Test Packages) CodeCoverage and Test Packages CodeCoverage and Test Packages succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Test for macOS Verify xUnit Results) Test for macOS Verify xUnit Results succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Test for macOS mac Test - ElevatedPesterTests - CI) Test for macOS mac Test - ElevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Test for macOS mac Test - ElevatedPesterTests - Others) Test for macOS mac Test - ElevatedPesterTests - Others succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Test for macOS mac Test - UnelevatedPesterTests - CI) Test for macOS mac Test - UnelevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Test for macOS mac Test - UnelevatedPesterTests - Others) Test for macOS mac Test - UnelevatedPesterTests - Others succeeded
Details
@azure-pipelines
PowerShell-CI-static-analysis Build #PR-15897-20210824.03 succeeded
Details
@azure-pipelines
PowerShell-CI-static-analysis (CI Compliance) CI Compliance succeeded
Details
@azure-pipelines
PowerShell-CI-static-analysis (Markdown and Common Tests) Markdown and Common Tests succeeded
Details
@azure-pipelines
PowerShell-CI-windows Build #PR-15897-20210824.03 succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Build for Windows Windows Build) Build for Windows Windows Build succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Test for Windows Verify xUnit Results) Test for Windows Verify xUnit Results succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Test for Windows Windows Test - ElevatedPesterTests - CI) Test for Windows Windows Test - ElevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Test for Windows Windows Test - ElevatedPesterTests - Others) Test for Windows Windows Test - ElevatedPesterTests - Others succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Test for Windows Windows Test - UnelevatedPesterTests - CI) Test for Windows Windows Test - UnelevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Test for Windows Windows Test - UnelevatedPesterTests - Others) Test for Windows Windows Test - UnelevatedPesterTests - Others succeeded
Details
@azure-pipelines
SSH-Tests Build #PR-15897-20210824.03 succeeded
Details
@wip
WIP Ready for review
Details
@microsoft-cla
license/cla All CLA requirements met.
Details
hayhay27 added a commit to hayhay27/PowerShell that referenced this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants