-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
DOC Ensures MultiOutput* and RegressorChain passes numpydoc validation #20713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@glemaitre It gets rendered as: But, I am not sure where/how to fix it. It's line 412 here: @property
def predict_proba(self):
"""Probability estimates.
Returns prediction probabilities for each class of each output.
This method will raise a ``ValueError`` if any of the
estimators do not have ``predict_proba``. |
The property bad rendering should not be the issue. It is indeed not a nice rendering but the introduction of |
Should I be commenting out all 4 of these in __all__ = [
"MultiOutputRegressor",
"MultiOutputClassifier",
"ClassifierChain",
"RegressorChain",
] |
Yes if you are modifying the docstring of the other estimators, you can uncomment. I can update the title. |
Co-authored-by: Guillaume Lemaitre <[email protected]>
Since I merged yesterday the docstring for |
Thanks @reshamas |
scikit-learn#20713) Co-authored-by: Guillaume Lemaitre <[email protected]>
Reference Issues/PRs
Addresses #20308
What does this implement/fix? Explain your changes.
Fixes formatting to pass numpy validation tests for class
MultiOutput*
andRegressionChain
Any other comments?
#DataUmbrella LATAM sprint