seems like a change around fmt printing ?

Pretty much, except we don't even parse the info in the first place:

I'd be interested in taking this for fun ... seems a good start for newbie

/assign xuehaohu ?

we have some working code for this, will ask my colleague to clean it up. IIRC Marcello also had some code for this, I'll ping him on Slack so we don't duplicate work

as an additional note, we are moving away from vishvananda/netlink in favour of jsimonetti/rtnetlink/rtnl (safer, smaller)

yeah i already started to work on it. #1354
But as @insomniacslk mentioned, we want to move to jsimonetti/rtnetlink/rtnl.
Right not it does not support all necessary attributes. So we need to work on it first.

There will be a WIP PR soon with the current progress 👍

Make it two PRs. Showing the route has nothing to do with changing the netlink lib.

I need this for a demo next week, and my colleague's work is only for IPv6 routes, so I went ahead and created #1379 . However this is based on /proc/net/route like the original code, which does not provide as much information as rtnetlink. A better PR can come later

CC @sylvblck

I didn't reload the browser and didn't see @hugelgupf 's and @sylvblck 's replies until now. How about #1379 as a stop-gap until @sylvblck 's change is completed?

a quick chat with @sylvblck and looked at #1354 and my PR doesn't make sense anymore :) I'll close my PR in favour of reopening #1354

I rebased and reopened #1354 👍 it's working fine on my test setup

@sylvblck mind sharing some local test setup ? - I can pick up the ipv6 implementation since it is related to my current work

I think the local test setup is... run it on your friendly local Linux machine (e.g. run it on your workstation and compare to system's ip route show...)

for the moment.

ah.. ok! - ideally we like them be the same right ? at least the values if not the printing format

@10000TB I'm using libvirt with direct kernel boot for each vm.
In this way it is possible to define host and network per xml file with virt-manager or by hand (for the specific use-case) and interact by using virtsh. Still not done with the setup but it may be worth for a blog post 😄

i ill be interested in checkout out the post to come

not familiar with the libvirt - but sounds like you are starting vms per configs, and run ip cmd within vms to verify if they match what is in configs

if setup is checked in repo, it would be super helpful

Trying to find inspiration for ipv6 implementation, so far I found this https://github.com/shemminger/iproute2/blob/master/ip/iproute.c#L1691 - still reading and digesting

but meanwhile want to post it here and see if more experienced people have any other suggestion

Actually, I think @sylvblck's patchset is probably better inspiration for v6 than the C code: you should be able to call netlink.RouteList with family FAMILY_V6. Probably an easier thread to pull on than that C code.

btw @10000TB I wrote basic support to show IPv6 routes on my PR #1354, but there are still a lot of work to do. ( e.g. a better approach to format a route entry, add IPv6 route preference -> pref, entries where you add mtu ...)

noted

being dead on this for so long, trying to recollect and pick up original promises as I am coming back to work on network boot stuff ...

Fair to close this issue ? per #1354