The Wayback Machine - https://web.archive.org/web/20230107053346/https://github.com/dotnet/wpf/pull/5084
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WindowsDesktop SDK to support recent changes to implicit global usings feature #5084

Merged
merged 2 commits into from Aug 18, 2021

Conversation

RussKie
Copy link
Member

@RussKie RussKie commented Aug 17, 2021

Relates to dotnet/sdk#19521
Relates to dotnet/sdk#19599

Related dotnet/winforms#5432
Related dotnet/winforms#5433

@ryalanms please take over it.

@msftbot msftbot bot added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 17, 2021
@msftbot msftbot bot requested review from fabiant3, ryalanms and SamBent Aug 17, 2021
@RussKie RussKie added this to the 6.0.0 milestone Aug 17, 2021
@ryalanms
Copy link
Member

ryalanms commented Aug 17, 2021

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 17, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@ryalanms ryalanms marked this pull request as ready for review Aug 17, 2021
@ryalanms ryalanms requested a review from a team as a code owner Aug 17, 2021
@ryalanms ryalanms changed the title Update SDK Update WindowsDesktop SDK to support recent changes to implicit global usings feature Aug 17, 2021
@ryalanms
Copy link
Member

ryalanms commented Aug 17, 2021

@SamBent: This updates WPF's implicit global using support to the naming and default value changes made in the SDK. I'd like to take it for RC1, if possible.

@ryalanms ryalanms merged commit 123b057 into main Aug 18, 2021
9 checks passed
@vishalmsft vishalmsft deleted the Update_SDK branch Feb 10, 2022
@msftbot msftbot bot locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants