The Wayback Machine - https://web.archive.org/web/20220814024715/https://github.com/PowerShell/PowerShell/pull/15873
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FileSystemProvider to work with volume and pipe paths #15873

Merged
merged 6 commits into from Jul 25, 2022
Merged

Fix FileSystemProvider to work with volume and pipe paths #15873

merged 6 commits into from Jul 25, 2022

Conversation

SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Aug 4, 2021 •
edited

PR Summary

A change in the FileSystemProvider to get the correct casing for a path regressed working with NTFS volume paths that start with \\?\ as it's not a UNC path so skips that handling. Also, the logic for handling a trailing directory separator relied on there to be no content so something like: "c:\foo\\bar" would handle this incorrectly.

Fix is to skip the first parts of the path even if it's not a UNC path, but starts with "\\?\". Then we only check for empty content if we are at the end of the path to handle trailing separator correctly.

Also supports \\.\pipe on Windows

PR Context

Fix #15872

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from anmenaga as a code owner Aug 4, 2021
@SteveL-MSFT SteveL-MSFT requested a review from iSazonov Aug 4, 2021
@fMichaleczek
Copy link

fMichaleczek commented Aug 5, 2021 •
edited by unfurl-links[bot] bot

@SteveL-MSFT Maybe good to take the #11898 in consideration while resolving this path problem.

Both examples work on Windows PowerShell

Get-ChildItem '//./pipe/'
Get-ChildItem '\\.\pipe\'

Found in this Rancher Wins documentation
https://github.com/rancher/wins#examples

GitHub
Windows containers connect to Windows host. Contribute to rancher/wins development by creating an account on GitHub.

@iSazonov
Copy link
Collaborator

iSazonov commented Aug 5, 2021

I'd merge #14469 first. Then we could start moving to new .Net API with #12834 and continue with other scenarios. After all, it would have corrected most of the issues we know in FileSystem provider.

@iSazonov
Copy link
Collaborator

iSazonov commented Aug 17, 2021

For reference #10805

@msftbot msftbot bot added the Review - Needed label Aug 24, 2021
@msftbot
Copy link

msftbot bot commented Aug 24, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@adityapatwardhan
Copy link
Member

adityapatwardhan commented May 6, 2022

@SteveL-MSFT Can you resolve conflicts?

@msftbot msftbot bot removed the Review - Needed label May 6, 2022
@msftbot msftbot bot added the Review - Needed label May 14, 2022
@msftbot
Copy link

msftbot bot commented May 14, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@SteveL-MSFT SteveL-MSFT changed the title Fix FileSystemProvider to work with volume paths Fix FileSystemProvider to work with volume and pipe paths Jun 20, 2022
@pull-request-quantifier
Copy link

pull-request-quantifier bot commented Jun 29, 2022

This PR has 29 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +19 -10
Percentile : 11.6%

Total files changed: 3

Change summary by file extension:
.cs : +11 -10
.ps1 : +8 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  👌  👎 (Email)
Customize PullRequestQuantifier for this repository.

@SteveL-MSFT
Copy link
Member Author

SteveL-MSFT commented Jul 25, 2022

@adityapatwardhan fixed merge conflict

@msftbot msftbot bot removed the Review - Needed label Jul 25, 2022
@msftbot msftbot bot added the Waiting on Author label Jul 25, 2022
@adityapatwardhan adityapatwardhan enabled auto-merge (squash) Jul 25, 2022
@adityapatwardhan adityapatwardhan merged commit d72cedd into PowerShell:master Jul 25, 2022
39 checks passed
@SteveL-MSFT SteveL-MSFT deleted the dir-iso branch Jul 25, 2022
@iSazonov iSazonov added CL-General and removed Waiting on Author labels Jul 26, 2022
@msftbot
Copy link

msftbot bot commented Aug 12, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.🎉

Handy links:

@msftbot msftbot bot mentioned this pull request Aug 12, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fMichaleczek fMichaleczek

@iSazonov iSazonov

@adityapatwardhan adityapatwardhan

@anmenaga anmenaga

Assignees

@adityapatwardhan adityapatwardhan

Labels
CL-General Extra Small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get-ChildItem of (Get-Volume) Paths does not work as expected
4 participants
@SteveL-MSFT @fMichaleczek @iSazonov @adityapatwardhan