The Wayback Machine - https://web.archive.org/web/20220319011300/https://github.com/vuejs/vue/issues/11575
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unknown custom element: <foreignObject> #11575

Closed
ThomasR opened this issue Aug 7, 2020 · 1 comment · Fixed by #11576
Closed

Unknown custom element: <foreignObject> #11575

ThomasR opened this issue Aug 7, 2020 · 1 comment · Fixed by #11576
Labels
bug has PR has workaround

Comments

@ThomasR
Copy link

@ThomasR ThomasR commented Aug 7, 2020 •
edited

Version

2.6.11

Reproduction link

https://jsfiddle.net/0jh1psog/

Steps to reproduce

Open the console in the provided JSFiddle
or
run Vue.config.getTagNamespace('foreignObject')

What is expected?

Vue.config.getTagNamespace('foreignObject') should return 'svg'

What is actually happening?

It returns undefined.

This causes a warning Unknown custom element: <foreignObject> when testing such components using vue-test-utils

This is caused by

vue/src/platforms/web/util/element.js

Line 29 in 52719cc

'foreignObject,g,glyph,image,line,marker,mask,missing-glyph,path,pattern,' +

It should be foreignobject with lowercase o here, because of the makeMap implementation.

To avoid such bugs in the future, even better fix:

vue/src/shared/util.js

Line 113 in 6fe07eb

map[list[i]] = true

should be map[expectsLowerCase ? list[i].toLowerCase() : list[i]] = true
@ThomasR
Copy link
Author

@ThomasR ThomasR commented Aug 7, 2020 •
edited

Workaround (can go for example in one of your Jest setup files):

import Vue from 'vue';
const { getTagNamespace } = Vue.config;
Vue.config.getTagNamespace = (tag) => {
   if (tag.toLowerCase() === 'foreignobject') {
        return 'svg';
    }
    return getTagNamespace(tag);
};

@posva posva mentioned this issue Aug 7, 2020
Merged
13 tasks
posva added a commit that referenced this issue Aug 7, 2020
@posva
fix: give correct namespace to foreignObject
bf84687 
Fix #11575
@posva posva closed this in #11576 Mar 30, 2021
posva added a commit that referenced this issue Mar 30, 2021
@posva
fix: give correct namespace in foreignObject (#11576)
af5e05d 
Fix #11575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug has PR has workaround
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

fix: give correct namespace in foreignObject
2 participants
@ThomasR @posva