The Wayback Machine - https://web.archive.org/web/20210124105033/https://github.com/sql-js/sql.js/pull/320
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] support build with custom (non-standard) functions #320

Draft
wants to merge 1 commit into
base: master
from

Conversation

@brodybits
Copy link
Contributor

@brodybits brodybits commented Jan 9, 2020

This is just an idea of how it may be possible to support developers who need to build with non-standard functions. Here is an example where I support UPPER and LOWER functions that can handle many EU characters properly: https://github.com/brodybits/sql.js/tree/custom-eu-string-functions

This idea includes some comments that I think should be considered in src/api.coffee that can help make it easier for people like myself to add custom functions in the future.

I suspect there should be a much smarter way to do this, by using an array of FuncDef structures like they do in extension-functions.c for example.

I will very likely continue with the kind of solution proposed here to support the needs of my customer, with hope for a more standardized solution (someday).

@brodybits brodybits force-pushed the brodybits:custom-functions branch from 86865e6 to e316007 Jan 9, 2020
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript
@brodybits brodybits force-pushed the brodybits:custom-functions branch from 06f6789 to 6a20a45 Jan 12, 2020
brodybits referenced this pull request in brodybits/sql.js Jan 13, 2020
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript

as proposed in: https://github.com/kripken/sql.js/pull/320
brodybits referenced this pull request in brodybits/sql.js Jan 13, 2020
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript

as proposed in: https://github.com/kripken/sql.js/pull/320
brodybits referenced this pull request in brodybits/sql.js Jan 13, 2020
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript

as proposed in: https://github.com/kripken/sql.js/pull/320
@lovasoa lovasoa force-pushed the sql-js:master branch from b3211a6 to e902ec2 Feb 29, 2020
@brodybits brodybits mentioned this pull request Apr 2, 2020
@lovasoa lovasoa force-pushed the sql-js:master branch from 351ffdd to 6e7ec33 Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant