The Wayback Machine - https://web.archive.org/web/20220309175052/https://github.com/jwt/ruby-jwt/pull/231
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show backtrace if rbnacl-libsodium not loaded #231

Merged

Conversation

buzztaiki
Copy link
Contributor

@buzztaiki buzztaiki commented Sep 8, 2017

I think that backtrace should be shown to make to solve problem as easy when rbnacl-libsodium is not loaded.

@sourcelevel-bot
Copy link

@sourcelevel-bot sourcelevel-bot bot commented Sep 8, 2017

Hello, @buzztaiki! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@excpt excpt self-assigned this Sep 9, 2017
@excpt excpt self-requested a review Sep 9, 2017
@excpt excpt added this to the Version 2.1.0 milestone Sep 11, 2017
@excpt
Copy link
Member

@excpt excpt commented Oct 5, 2017

@buzztaiki Thanks for the PR. This really makes the usage a lot easier.

excpt
excpt approved these changes Oct 5, 2017
@excpt excpt merged commit f943b9d into jwt:master Oct 5, 2017
3 checks passed
@buzztaiki buzztaiki deleted the show-backtrace-if-rbnacl-libsodium-not-loaded branch Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants