Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
simplified logic for keyfinder #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcelevel-bot[bot]](https://web.archive.org/web/20220309191943im_/https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
lib/jwt.rb
Outdated
| end | ||
| raise JWT::DecodeError, 'No verification key available' unless key | ||
| end | ||
| key = keyfinder.call(header, payload) if keyfinder |
There was a problem hiding this comment.
Use yield instead of keyfinder.call.
ab320012
force-pushed
the
keyfinder-simplify
branch
2 times, most recently
from
a87f65f
to
cb3c2ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
was looking into adding docs for keyfinder, realized none of params decode takes are documented but also saw a way to simplify if statement, the tests still pass although i am not sure there is a test with keyfinder, let me know if i need to add one.