The Wayback Machine - https://web.archive.org/web/20200906103413/https://github.com/jwt/ruby-jwt/pull/341/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more docs about JWK support #341

Merged
merged 1 commit into from Sep 1, 2020
Merged

Add more docs about JWK support #341

merged 1 commit into from Sep 1, 2020

Conversation

@take
Copy link
Contributor

take commented Nov 26, 2019

@sourcelevel-bot
Copy link

sourcelevel-bot bot commented Nov 26, 2019

Hello, @take! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

or by passing JWK as a simple Hash

```
jwks = { keys: [{ ... }] } # keys needs to be Symbol

This comment has been minimized.

@martinemde

martinemde Mar 25, 2020

Contributor

I added #348 to accept string keys. If that gets merged, this will need an update.

This comment has been minimized.

@excpt

excpt Jul 7, 2020

Member

If it's okay for you I would merge this doc update. Then you can rebase your PR and add the new documentation information.

@take
Copy link
Contributor Author

take commented Mar 25, 2020

@bkeepers would help if you can look into this since there's relative PRs already 🙇

@excpt excpt added the documentation label Jul 7, 2020
@excpt
excpt approved these changes Jul 7, 2020
@excpt excpt merged commit d312d1d into jwt:master Sep 1, 2020
3 checks passed
3 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
sourcelevel SourceLevel did not find any new or fixed issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.