The Wayback Machine - https://web.archive.org/web/20210617081626/https://github.com/jwt/ruby-jwt/pull/376
Skip to content

/ ruby-jwt

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Rails cops #376

Merged
merged 1 commit into from Oct 2, 2020
Merged

Disable Rails cops #376

merged 1 commit into from Oct 2, 2020

Conversation

@anakinj
Copy link
Member

@anakinj anakinj commented Oct 2, 2020

Having the Rails Cops enabled gives false warnings about Rails specific syntax. For example it suggest using delegate even if the gem does not use activesupport that provides this functionality.
@anakinj
Disable Rails cops
e57443a
@sourcelevel-bot
Copy link

@sourcelevel-bot sourcelevel-bot bot commented Oct 2, 2020

SourceLevel has finished reviewing this Pull Request and has found:

  • 1 fixed issue! 🎉

See more details about this review.
@excpt
excpt approved these changes Oct 2, 2020
View changes
@excpt excpt merged commit 82680f0 into jwt:master Oct 2, 2020
3 checks passed
3 checks passed
codeclimate 2 fixed issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sourcelevel-bot
sourcelevel SourceLevel has found 1 fixed issue.
Details
@excpt
Copy link
Member

@excpt excpt commented Oct 2, 2020 •
edited

🥳 Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@excpt excpt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@anakinj @excpt