The Wayback Machine - https://web.archive.org/web/20210617084652/https://github.com/jwt/ruby-jwt/pull/397
Skip to content

/ ruby-jwt

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving the local development experience #397

Merged
merged 1 commit into from Feb 9, 2021
Merged

Improving the local development experience #397

merged 1 commit into from Feb 9, 2021

Conversation

@anakinj
Copy link
Member

@anakinj anakinj commented Dec 25, 2020 •
edited

Yet another PR to improve the development experience for all of us.

Added:

  • Local coverage reports
  • Ruby 3.0 tests on CI
  • Documentation about how to run all different 3rd party combinations using Appraisal
  • Generic rake default task executing RuboCop and the tests.

Removed:

  • Codacy gem dependency, have not seen any reports from there and not sure if we really use it. So just removed it....
@anakinj anakinj force-pushed the anakinj:coverage-and-testing branch from 1ed85ba to c4654bf Dec 25, 2020
@yasonk
yasonk approved these changes Feb 5, 2021
View changes
Copy link
Contributor

@yasonk yasonk left a comment

Downloaded the branch and was able to run the tests.
Also don't see any issues with the code
@yasonk
yasonk approved these changes Feb 5, 2021
View changes
@anakinj
Copy link
Member Author

@anakinj anakinj commented Feb 6, 2021

Thanks @yasonk for the feedback and reminder, had forgotten all about this. I think I'll take a look at this and merge it later today.
@anakinj anakinj force-pushed the anakinj:coverage-and-testing branch 2 times, most recently from d6c9dde to df8cc48 Feb 8, 2021
@anakinj
Improving the local development experience
a2b0946
@anakinj anakinj force-pushed the anakinj:coverage-and-testing branch from df8cc48 to a2b0946 Feb 9, 2021
@anakinj anakinj merged commit f4925cd into jwt:master Feb 9, 2021
25 checks passed
25 checks passed
@github-actions
RuboCop
Details
@github-actions
test (2.3, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.3, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.4, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.5, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.6, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (2.7, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (3, gemfiles/standalone.gemfile, false)
Details
@github-actions
test (3, gemfiles/openssl.gemfile, false)
Details
@github-actions
test (3, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.1, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (2.2, gemfiles/rbnacl.gemfile, false)
Details
@github-actions
test (ruby-head, true)
Details
@github-actions
test (truffleruby-head, true)
Details
codeclimate All good!
Details
@sourcelevel-bot
sourcelevel SourceLevel did not find any new or fixed issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasonk yasonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@anakinj @yasonk