The Wayback Machine - https://web.archive.org/web/20210824234937/https://github.com/RustPython/RustPython/issues/2812
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing deque methods #2812

Open
4 of 6 tasks
DimitrisJim opened this issue Aug 8, 2021 · 6 comments
Open
4 of 6 tasks

Add missing deque methods #2812

DimitrisJim opened this issue Aug 8, 2021 · 6 comments

Comments

@DimitrisJim
Copy link
Task lists! Give feedback
Member

@DimitrisJim DimitrisJim commented Aug 8, 2021

Current basic methods are not implemented on deque:

@OhBonsai
Copy link
Contributor

@OhBonsai OhBonsai commented Aug 9, 2021

Hi, I would like to do some work on this. Could you @DimitrisJim get me up to speed quickly on this? :)

@DimitrisJim
Copy link
Member Author

@DimitrisJim DimitrisJim commented Aug 9, 2021

Of course @OhBonsai. You can start by taking a look at the other methods implemented for deque, these will give you an idea on how to manipulate the underlying VecDeque to get the behavior needed. You can drop in at gitter and ask about anything if you get stuck at some point.

@DimitrisJim
Copy link
Member Author

@DimitrisJim DimitrisJim commented Aug 10, 2021

Hey @OhBonsai , pick one of the issues linked and I can assign it to you and guide you through anything you need over there.

@whgusdn321
Copy link
Contributor

@whgusdn321 whgusdn321 commented Aug 11, 2021

@OhBonsai Hello I'm interested in this issue also. If you don't mind, I would like to contribute some of them. would it be possible? and if it's okay, what are you going to implement among these? I'll implement the ones you don't pick.
( collections.deque doesn't have add method #2835
collections.deque doesn't have a bool method. #2837
collections.deque doesn't have iadd method. #2838
collections.deque doesn't have imul method. #2839
collections.deque does not have rmul method #2834
collections.deque doesn't have reversed method #2836)

@OhBonsai
Copy link
Contributor

@OhBonsai OhBonsai commented Aug 11, 2021

@whgusdn321 Wows, It's seem like i can ride your coattails 😄 .

I think i could choosebool. It looks simpler~. BTW add/iadd/imul/rmul have been assigned~. Just reversed leaved 😢

@youknowone
Copy link
Member

@youknowone youknowone commented Aug 11, 2021

general tip: list and tuple have similar implementations for similar magic methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants