The Wayback Machine - https://web.archive.org/web/20211022225312/https://github.com/python/mypy/pull/10837
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove return output in refine_parent_types #10837

Merged
merged 1 commit into from Sep 21, 2021
Merged

Remove return output in refine_parent_types #10837

merged 1 commit into from Sep 21, 2021

Conversation

@donno2048
Copy link
Contributor

@donno2048 donno2048 commented Jul 18, 2021

Description

An unnecessary default return was removed, return (or any other statement) after a while True with no break condition will never be executed
@donno2048
remove `return output`
1426b1a 
`return` (or any other statement) after a `while True` with no `break` condition will never be executed
JukkaL
JukkaL approved these changes Sep 21, 2021
View changes
@JukkaL JukkaL merged commit 58fb493 into python:master Sep 21, 2021
6 checks passed
@donno2048 donno2048 deleted the patch-1 branch Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JukkaL JukkaL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@donno2048 @JukkaL