The Wayback Machine - https://web.archive.org/web/20210826034437/https://github.com/home-assistant/core/pull/53783
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vscode task code coverage #53783

Merged
merged 2 commits into from Aug 5, 2021

Conversation

@mib1185
Copy link
Contributor

@mib1185 mib1185 commented Jul 30, 2021

Proposed change

This will add a new VSCode task to start code coverage report for a specific integration:

image

image

image

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jul 30, 2021
Dev automation moved this from Needs review to Reviewer approved Jul 31, 2021
Copy link
Member

@janiversen janiversen left a comment

LGTM. A nice addition !! Thanks @mib1185

Copy link
Member

@ludeeus ludeeus left a comment

component -> integration

.vscode/tasks.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
Co-authored-by: Joakim Sørensen <[email protected]>
@ludeeus
ludeeus approved these changes Aug 5, 2021
@ludeeus ludeeus merged commit 29e604b into home-assistant:dev Aug 5, 2021
5 checks passed
5 checks passed
@github-actions
Prepare base dependencies
Details
@github-actions
Prepare tests for Python 3.8
Details
@github-actions
Prepare tests for Python 3.9
Details
@homeassistant
cla-bot Everyone involved has signed the CLA
@probot-home-assistant
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Aug 5, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants