Add type annotations to amcrest integration #54761
Merged
+282
â1¤7165
Conversation
#55092 addresses the comments on using the entity description, and can land before this change. Pulling into draft until that change lands. |
This is merged with the latest changes on |
Nice, thanks @flacjacket |
Please address the comment in a new PR. Thanks! |
"""Subscribe to signals.""" | ||
assert self.hass is not None |
MartinHjelmare
Aug 26, 2021
Member
This assertion shouldn't be needed.
core/homeassistant/helpers/entity.py
Lines 205 to 208
in
3d7bfa8
This assertion shouldn't be needed.
core/homeassistant/helpers/entity.py
Lines 205 to 208 in 3d7bfa8
8 of 22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Proposed change
Add type annotations to the amcrest component and enable strict type checking for the integration. The behavior of the component is unchanged.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: