The Wayback Machine - https://web.archive.org/web/20210826035009/https://github.com/home-assistant/core/pull/54761
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations to amcrest integration #54761

Merged
merged 9 commits into from Aug 25, 2021

Conversation

@flacjacket
Copy link
Contributor

@flacjacket flacjacket commented Aug 17, 2021

Proposed change

Add type annotations to the amcrest component and enable strict type checking for the integration. The behavior of the component is unchanged.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Aug 17, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 17, 2021
@frenck frenck added the smash label Aug 17, 2021
@frenck frenck removed the smash label Aug 18, 2021
@flacjacket flacjacket requested review from janiversen and frenck Aug 19, 2021
@flacjacket
Copy link
Contributor Author

@flacjacket flacjacket commented Aug 23, 2021

#55092 addresses the comments on using the entity description, and can land before this change. Pulling into draft until that change lands.

@flacjacket flacjacket marked this pull request as draft Aug 23, 2021
@flacjacket flacjacket force-pushed the flacjacket:amcrest_mypy branch from aab0612 to 7786d9b Aug 24, 2021
@flacjacket flacjacket marked this pull request as ready for review Aug 24, 2021
@flacjacket
Copy link
Contributor Author

@flacjacket flacjacket commented Aug 25, 2021

This is merged with the latest changes on dev and ready for another look!

@frenck frenck added the smash label Aug 25, 2021
@frenck
frenck approved these changes Aug 25, 2021
Copy link
Member

@frenck frenck left a comment

Nice, thanks @flacjacket 👍

Dev automation moved this from By Code Owner to Reviewer approved Aug 25, 2021
@frenck frenck merged commit 6b4e3bc into home-assistant:dev Aug 25, 2021
30 checks passed
30 checks passed
@github-actions
Prepare base dependencies
Details
@github-actions
Prepare tests for Python 3.8
Details
@github-actions
Prepare tests for Python 3.9
Details
@github-actions
Check bandit
Details
@github-actions
Check black
Details
@github-actions
Check codespell
Details
@github-actions
Check Dockerfile
Details
@github-actions
Check executables
Details
@github-actions
Check flake8
Details
@github-actions
Check isort
Details
@github-actions
Check JSON
Details
@github-actions
Check pyupgrade
Details
@github-actions
Check YAML
Details
@github-actions
Check all requirements
Details
@github-actions
Check hassfest (3.8)
Details
@github-actions
Check pylint (3.8)
Details
@github-actions
Check mypy (3.8)
Details
@github-actions
Run tests Python 3.8 (group 1)
Details
@github-actions
Run tests Python 3.9 (group 1)
Details
@github-actions
Run tests Python 3.8 (group 2)
Details
@github-actions
Run tests Python 3.9 (group 2)
Details
@github-actions
Run tests Python 3.8 (group 3)
Details
@github-actions
Run tests Python 3.9 (group 3)
Details
@github-actions
Run tests Python 3.8 (group 4)
Details
@github-actions
Run tests Python 3.9 (group 4)
Details
@github-actions
Process test coverage (3.8)
Details
@homeassistant
cla-bot Everyone involved has signed the CLA
@codecov
codecov/patch Coverage not affected when comparing de7352d...1dc03a6
Details
@codecov
codecov/project 96.59% (target 90.00%)
Details
@probot-home-assistant
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Aug 25, 2021
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Please address the comment in a new PR. Thanks!

"""Subscribe to signals."""
assert self.hass is not None

This comment has been minimized.

@MartinHjelmare

MartinHjelmare Aug 26, 2021
Member

This assertion shouldn't be needed.

# Owning hass instance. Will be set by EntityPlatform
# While not purely typed, it makes typehinting more useful for us
# and removes the need for constant None checks or asserts.
hass: HomeAssistant = None # type: ignore

This comment has been minimized.

@flacjacket

flacjacket Aug 26, 2021
Author Contributor

Thanks for pointing that out! Added a fix for this and other asserts in #55244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants