The Wayback Machine - https://web.archive.org/web/20210826034746/https://github.com/home-assistant/core/pull/55177
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logging to do rollover() instead of rotate() #55177

Merged
merged 2 commits into from Aug 25, 2021

Conversation

@janiversen
Copy link
Member

@janiversen janiversen commented Aug 24, 2021

Breaking change

#54865 secured that homeassistant.log was backed up, by using .rotate() however it has the side effect that logging continues in the new file.
Go back to the original #54865 and use .doRollover() this renames homeassistant.log to homeassistant.log.1 and open a new file homeassistant.log

This means that homeassistant.log is the current (active/open) log, and homeassistant.log.1 is from last start of hass.

If log_rotate_days us used there will be multiple files (.1 .2 ... until log_rotate_days) each log will be either a midnight change or a start of hass.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

With 2021.8.8 homeasistant.log is effectively homeassistant.previous.log !!

  • This PR fixes or closes issue: fixes #
    fixes #55144
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@janiversen janiversen requested a review from home-assistant/core as a code owner Aug 24, 2021
@project-bot project-bot bot added this to Needs review in Dev Aug 24, 2021
@janiversen janiversen force-pushed the janiversen:issue_55144 branch from 861679f to eb9a77d Aug 24, 2021
Dev automation moved this from Needs review to Reviewer approved Aug 24, 2021
@janiversen janiversen force-pushed the janiversen:issue_55144 branch from eb9a77d to ff35033 Aug 25, 2021
@frenck frenck added the smash label Aug 25, 2021
@janiversen janiversen force-pushed the janiversen:issue_55144 branch from ff35033 to f000e7e Aug 25, 2021
@janiversen janiversen force-pushed the janiversen:issue_55144 branch 3 times, most recently from d1a75fb to a8ee15f Aug 25, 2021
@janiversen janiversen force-pushed the janiversen:issue_55144 branch from a8ee15f to 75df709 Aug 25, 2021
@janiversen janiversen merged commit 3a0a8da into home-assistant:dev Aug 25, 2021
30 checks passed
30 checks passed
@github-actions
Prepare base dependencies
Details
@github-actions
Prepare tests for Python 3.8
Details
@github-actions
Prepare tests for Python 3.9
Details
@github-actions
Check bandit
Details
@github-actions
Check black
Details
@github-actions
Check codespell
Details
@github-actions
Check Dockerfile
Details
@github-actions
Check executables
Details
@github-actions
Check flake8
Details
@github-actions
Check isort
Details
@github-actions
Check JSON
Details
@github-actions
Check pyupgrade
Details
@github-actions
Check YAML
Details
@github-actions
Check all requirements
Details
@github-actions
Check hassfest (3.8)
Details
@github-actions
Check pylint (3.8)
Details
@github-actions
Check mypy (3.8)
Details
@github-actions
Run tests Python 3.8 (group 1)
Details
@github-actions
Run tests Python 3.9 (group 1)
Details
@github-actions
Run tests Python 3.8 (group 2)
Details
@github-actions
Run tests Python 3.9 (group 2)
Details
@github-actions
Run tests Python 3.8 (group 3)
Details
@github-actions
Run tests Python 3.9 (group 3)
Details
@github-actions
Run tests Python 3.8 (group 4)
Details
@github-actions
Run tests Python 3.9 (group 4)
Details
@github-actions
Process test coverage (3.8)
Details
@homeassistant
cla-bot Everyone involved has signed the CLA
@codecov
codecov/patch 100.00% of diff hit (target 96.59%)
Details
@codecov
codecov/project 96.59% (target 90.00%)
Details
@probot-home-assistant
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Aug 25, 2021
@janiversen janiversen deleted the janiversen:issue_55144 branch Aug 25, 2021
raman325 added a commit to raman325/home-assistant that referenced this pull request Aug 25, 2021
* upstream/dev: (588 commits)
  Add select platform to template integration (home-assistant#54835)
  Honeywell Lyric - Entity Descriptions (home-assistant#54956)
  Add tests for Rituals init, sensor and switch (home-assistant#52406)
  Support for EnergyStorageTrait for vacuum cleaners (home-assistant#55134)
  Add support for Xiaomi Miio pedestal fans (home-assistant#55114)
  Sonos add bass & treble EQ option (home-assistant#53978)
  Address review of Nanoleaf Config Flow (home-assistant#55215)
  Implement color_mode support for mysensors (home-assistant#52068)
  Change logging to do rollover() instead of rotate() (home-assistant#55177)
  Support device triggers in HomeKit (home-assistant#53869)
  Remove temperature conversion - sht31 (home-assistant#55213)
  Finish EntityDescription implementation for RainMachine (home-assistant#55180)
  Remove temperature conversion - synology_dsm (home-assistant#55214)
  Report average of position and tilt_position for cover groups (home-assistant#52713)
  Ignore unsupported MeasureType-s from Withings (home-assistant#55205)
  Prevent setting _attr_unit_of_measurement in subclasses of SensorEntity (home-assistant#55211)
  Fix Fjäråskupan RSSI sensor unit (home-assistant#55210)
  ESPHome sensor use total_increasing state class (home-assistant#55208)
  Remove should poll property from Xiaomi Miio fan platform (home-assistant#55201)
  Fix last_reset in utility_meter (home-assistant#55209)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants