Change logging to do rollover() instead of rotate() #55177
Merged
+8
â1¤73
Conversation
d1a75fb
to
a8ee15f
3a0a8da
into
home-assistant:dev
30 checks passed
30 checks passed
raman325
added a commit
to raman325/home-assistant
that referenced
this pull request
Aug 25, 2021
* upstream/dev: (588 commits) Add select platform to template integration (home-assistant#54835) Honeywell Lyric - Entity Descriptions (home-assistant#54956) Add tests for Rituals init, sensor and switch (home-assistant#52406) Support for EnergyStorageTrait for vacuum cleaners (home-assistant#55134) Add support for Xiaomi Miio pedestal fans (home-assistant#55114) Sonos add bass & treble EQ option (home-assistant#53978) Address review of Nanoleaf Config Flow (home-assistant#55215) Implement color_mode support for mysensors (home-assistant#52068) Change logging to do rollover() instead of rotate() (home-assistant#55177) Support device triggers in HomeKit (home-assistant#53869) Remove temperature conversion - sht31 (home-assistant#55213) Finish EntityDescription implementation for RainMachine (home-assistant#55180) Remove temperature conversion - synology_dsm (home-assistant#55214) Report average of position and tilt_position for cover groups (home-assistant#52713) Ignore unsupported MeasureType-s from Withings (home-assistant#55205) Prevent setting _attr_unit_of_measurement in subclasses of SensorEntity (home-assistant#55211) Fix Fjäråskupan RSSI sensor unit (home-assistant#55210) ESPHome sensor use total_increasing state class (home-assistant#55208) Remove should poll property from Xiaomi Miio fan platform (home-assistant#55201) Fix last_reset in utility_meter (home-assistant#55209) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Breaking change
#54865 secured that homeassistant.log was backed up, by using .rotate() however it has the side effect that logging continues in the new file.
Go back to the original #54865 and use .doRollover() this renames homeassistant.log to homeassistant.log.1 and open a new file homeassistant.log
This means that homeassistant.log is the current (active/open) log, and homeassistant.log.1 is from last start of hass.
If log_rotate_days us used there will be multiple files (.1 .2 ... until log_rotate_days) each log will be either a midnight change or a start of hass.
Proposed change
Type of change
Additional information
With 2021.8.8 homeasistant.log is effectively homeassistant.previous.log !!
fixes #55144
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: