The Wayback Machine - https://web.archive.org/web/20211024091244/https://github.com/home-assistant/core/pull/54579
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ambiclimate #54579

Merged
merged 2 commits into from Aug 13, 2021
Merged

Fix bug in ambiclimate #54579

merged 2 commits into from Aug 13, 2021

Conversation

@Danielhiversen
Copy link
Member

@Danielhiversen Danielhiversen commented Aug 13, 2021

Signed-off-by: Daniel Hjelseth Høyer [email protected]

Breaking change

Proposed change

Fix bug in ambiclimate, introduce with class attributes #52521

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #54573, #53992
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@project-bot project-bot bot added this to Needs review in Dev Aug 13, 2021
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Aug 13, 2021
Signed-off-by: Daniel Hjelseth Høyer <[email protected]>
@ludeeus ludeeus added this to the 2021.8.7 milestone Aug 13, 2021
Dev automation moved this from By Code Owner to Reviewer approved Aug 13, 2021
@ludeeus ludeeus merged commit 821b93b into dev Aug 13, 2021
30 checks passed
Dev automation moved this from Reviewer approved to Done Aug 13, 2021
@ludeeus ludeeus deleted the ambiclimate branch Aug 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants