The Wayback Machine - https://web.archive.org/web/20220203064222/https://github.com/python/cpython/pull/27943
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] bpo-27334: roll back transaction if sqlite3 context manager fails to commit (GH-26202) #27943

Merged
merged 2 commits into from Aug 28, 2021
Merged

[3.10] bpo-27334: roll back transaction if sqlite3 context manager fails to commit (GH-26202) #27943

merged 2 commits into from Aug 28, 2021

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Aug 25, 2021 •
edited by bedevere-bot

Co-authored-by: Luca Citi
Co-authored-by: Berker Peksag [email protected].
(cherry picked from commit 7ecd342)

Co-authored-by: Erlend Egeberg Aasland [email protected]

https://bugs.python.org/issue27334
@bedevere-bot bedevere-bot mentioned this pull request Aug 25, 2021
Merged
@erlend-aasland erlend-aasland requested a review from pablogsal Aug 25, 2021
@erlend-aasland erlend-aasland marked this pull request as draft Aug 25, 2021
@erlend-aasland
[3.10] bpo-27334: roll back transaction if sqlite3 context manager fa…
3978e28 
…ils to commit (pythonGH-26202)

Co-authored-by: Luca Citi
Co-authored-by: Berker Peksag <[email protected]>.
(cherry picked from commit 7ecd342)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@erlend-aasland
bpo-27334: Fix ref. leak
3468d6c
@erlend-aasland erlend-aasland force-pushed the backport-7ecd342-3.10 branch from 439b1b0 to 3468d6c Aug 25, 2021
@erlend-aasland erlend-aasland marked this pull request as ready for review Aug 25, 2021
@erlend-aasland
Copy link
Contributor Author

@erlend-aasland erlend-aasland commented Aug 25, 2021

FYI, asyncio failed on Azure Pipelines CI.

@ambv
Copy link
Contributor

@ambv ambv commented Aug 25, 2021

I restarted it, all good.

@pablogsal pablogsal merged commit 2a80893 into python:3.10 Aug 28, 2021
13 checks passed
@erlend-aasland erlend-aasland deleted the backport-7ecd342-3.10 branch Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@berkerpeksag berkerpeksag

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@erlend-aasland @ambv @pablogsal @the-knights-who-say-ni @bedevere-bot