bpo-28474: Handle unsigned long win32 error codes #27959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameily
changed the title
ameily
changed the title
zooba
reviewed
Aug 26, 2021
| if (winerrcode == -1 && PyErr_Occurred()) | ||
| return -1; | ||
|
|
||
| if(winerrcode < LONG_MIN || winerrcode > ULONG_MAX) { |
There was a problem hiding this comment.
Suggested change
| if(winerrcode < LONG_MIN || winerrcode > ULONG_MAX) { | |
| if((int)winerrcode != winerrcode) { |
There was a problem hiding this comment.
From my understanding, this change would break error codes greater than LONG_MAX, which are still valid and this PR is adding support for. For example, this change raises an exception for a valid DWORD error code.
>>> OSError(0, '', None, 0x80000005)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
OverflowError: error code 2147483653 too big for int
|
This PR is stale because it has been open for 30 days with no activity. |
Co-authored-by: Steve Dower <[email protected]>
|
@zooba I've rebased from upstream/main and have addressed all feedback items, except one that I think it out of scope. Let me know if you need anything else from me. |
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
bpo-28474: Handle unsigned long win32 error codes
Windows Error Codes are
DWORDvalues. This PR ensures that error codes larger thanLONG_MAXare handled. Previously, an overflow exception was raised for large, but valid, win32 error codes, such asE_POINTER 0x80000005.https://bugs.python.org/issue28474