The Wayback Machine - https://web.archive.org/web/20201011182950/https://github.com/JSQLParser/JSqlParser/pull/257
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Oracle 'HAVING' & 'GROUP BY' reversed. #257

Conversation

@davelindquist-egistix
Copy link
Contributor

@davelindquist-egistix davelindquist-egistix commented Apr 28, 2016

Oracle allows the 'HAVING' clause and the 'GROUP BY' clause to be reversed (that is, the HAVING clause appearing first, followed by the GROUP BY clause). We've modified the parser grammar to support this, and updated tests.

This necessitated some changes to the "SpecialOracleTest" class, specifically:

  • Addition of the ability to have 'exceptions' to the 'execute all files in the directory' test.
  • Addition of a method to specifically test that exception.
  • Addition of an "after all tests are done" verification that all exceptions have been individually tested.
Oracle allows the 'HAVING' clause and the 'GROUP BY' clause to be
reversed (that is, the HAVING clause appearing first, followed by the
GROUP BY clause).  We've modified the parser grammar to support this,
and updated tests.

This necessitated some changes to the "SpecialOracleTest" class,
specifically:
* Addition of the ability to have 'exceptions' to the 'execute all files
  in the directory' test.
* Addition of a method to specifically test that exception.
* Addition of an "after all tests are done" verification that all
  exceptions have been individually tested.
@davelindquist-egistix davelindquist-egistix force-pushed the davelindquist-egistix:oracle-having-groupby-misordering branch from c128cdf to 139ee76 May 9, 2016
@davelindquist-egistix
Copy link
Contributor Author

@davelindquist-egistix davelindquist-egistix commented May 9, 2016

I've updated this branch (rebased it on latest master) to fix collisions with other changes in master. Enjoy! :-)

@coveralls
Copy link

@coveralls coveralls commented May 9, 2016

Coverage Status

Coverage remained the same at 83.506% when pulling 139ee76 on davelindquist-egistix:oracle-having-groupby-misordering into 77ba380 on JSQLParser:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.