The Wayback Machine - https://web.archive.org/web/20201011182958/https://github.com/JSQLParser/JSqlParser/pull/634
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: preparing fixes for PR. #634

Open
wants to merge 8 commits into
base: master
from
Open

Conversation

@wheredevel
Copy link

@wheredevel wheredevel commented Jul 3, 2018

No description provided.

Pavel Bekkerman added 7 commits Jul 3, 2018
Pavel Bekkerman
Pavel Bekkerman
Pavel Bekkerman
Pavel Bekkerman
Pavel Bekkerman
Pavel Bekkerman
Pavel Bekkerman
@coveralls
Copy link

@coveralls coveralls commented Jul 3, 2018

Coverage Status

Coverage decreased (-2.07%) to 83.852% when pulling cdc080b on wheredevel:fixes into b76e639 on JSQLParser:master.

Pavel Bekkerman
@wumpz
Copy link
Member

@wumpz wumpz commented Jul 26, 2018

So back from Holidays.

So we are going for the huge commit, do we? Should I look at the conflicting files or do you? Whats the next step?

@wheredevel
Copy link
Author

@wheredevel wheredevel commented Jul 27, 2018

Hi @wumpz .
I already solved all the conflicts. The PR passes the tests.
I saw a couple of commits you did after its submission.
If you could merge it with the current master - that would be great.
Let me know if my help is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.