Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upENH/API: allow hist.bins to follow the numpy default #16471
Draft
Conversation
Currently, we default to hist.bins=10 which happens to match the numpy default. However, there is some discussion about changing the numpy default. This adds the option of fall back to "what numpy does by default" by default.
This will have no effect, as the numpy default is currently the same as our default, but will future-proof us to follow numpy if / when they change their default.
|
Overall this seems fine but needs docs. I think this needs a what’s new? And the new kwarg value need an entry in the docstring. Probably the template comment needs to be changed |
|
Ok so this changes the default as well, right? |
|
Punting to 3.4 as I don't think this is urgent (as I don't think there is a pending change to the numpy default coming). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Currently, we default to hist.bins=10 which happens to match the numpy
default. However, there is some discussion about changing the numpy
default. This adds the option of fall back to "what numpy does by default"
by default.
Changing the default currently has no effect, as the numpy default is
the same as our ould default, but will future-proof us to follow numpy
if / when they change their default.