The Wayback Machine - https://web.archive.org/web/20210525042605/https://github.com/github/linguist/pull/5384
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the Java language color + match modern branding #5384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@ZacSweers
Copy link

@ZacSweers ZacSweers commented May 25, 2021

The previous color no longer matches the Java branding colors and hasn't aged well. This matches the newer branding

https://www.color-hex.com/color/2a6277

image

Checklist:

  • I am associating a language with a new file extension.

  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • I don't know necessarily where to create a wider discussion but happy to post somewhere you recommend!
      • https://twitter.com/java
The previous color no longer matches the Java branding colors and hasn't aged well. This matches the newer branding
@ZacSweers ZacSweers requested a review from github/linguist as a code owner May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant