tty/fit setraw acording to a man page #27599
Conversation
Hi there, Coincidentally I noticed that setraw explanation and python implementation is different. There's no comment why. So I just decided to open an issue but there's no issues here :( I would be nice to put a comment why some of the settings were omitted. And yes I think it might be a breaking change so it may not worth to be merged. But leave a comment would be welcomed :) ____ https://man7.org/linux/man-pages/man3/termios.3.html ``` Raw mode cfmakeraw() sets the terminal to something like the "raw" mode of the old Version 7 terminal driver: input is available character by character, echoing is disabled, and all special processing of terminal input and output characters is disabled. The terminal attributes are set as follows: termios_p->c_iflag &= ~(IGNBRK | BRKINT | PARMRK | ISTRIP | INLCR | IGNCR | ICRNL | IXON); termios_p->c_oflag &= ~OPOST; termios_p->c_lflag &= ~(ECHO | ECHONL | ICANON | ISIG | IEXTEN); termios_p->c_cflag &= ~(CSIZE | PARENB); termios_p->c_cflag |= CS8; ``` Thank you. And sorry for bothering.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Please open an issue on https://bugs.python.org/ for discussion. The PR needs a NEWS entry, tests, and maybe changes in the documentation if this is a new feature rather of a bug fix. |
|
This PR is stale because it has been open for 30 days with no activity. If the CLA is not signed within 14 days, it will be closed. See also https://devguide.python.org/pullrequest/#licensing |
|
Closing this stale PR because the CLA is still not signed. |
Hi there,
Coincidentally I noticed that
setrawexplanation on a man page and python implementation is different.There's no comment why.
So I just decided to open an issue but there's no issues here :(
It would be nice to put a comment why some of the settings were omitted.
And yes I think it might be a breaking change so it may not worth to be merged.
But leave a comment would be welcomed :)
https://man7.org/linux/man-pages/man3/termios.3.html
Thank you.
And sorry for bothering.