Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
bpo-43468: Per instance locking for functools.cached_property #27609
+66
−17
Conversation
|
It looks like |
| @@ -18,7 +18,7 @@ | |||
| from collections import namedtuple | |||
| # import types, weakref # Deferred to single_dispatch() | |||
| from reprlib import recursive_repr | |||
| from _thread import RLock | |||
| from threading import RLock, Condition, get_ident | |||
ambv
Aug 17, 2021
Contributor
This change introduces an import cycle which causes tests to fail.
This change introduces an import cycle which causes tests to fail.
| @@ -0,0 +1,3 @@ | |||
| Fixed locking for functools.cached_property() to have instance specific | |||
| locking. Formerly, it blocked all instances of the same class, making it | |||
| suitable for parallel I/O bound computations (which were a key use case). | |||
ptmcg
Aug 27, 2021
Do you mean "unsuitable"?
Do you mean "unsuitable"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Draft PR. It needs a NEWS entry, perhaps more tests, and perhaps some more factoring.
https://bugs.python.org/issue43468