The Wayback Machine - https://web.archive.org/web/20211027194122/https://github.com/python/cpython/pull/27841
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44524: Don't modify MRO when inheriting from typing.Annotated #27841

Merged
merged 5 commits into from Aug 25, 2021
Merged

bpo-44524: Don't modify MRO when inheriting from typing.Annotated #27841

merged 5 commits into from Aug 25, 2021

Conversation

@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented Aug 19, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44524
@Fidget-Spinner
exclude Annotated from _name temporarily
ce19238
@Fidget-Spinner
stricter tests
a943fce
@Fidget-Spinner Fidget-Spinner requested a review from gvanrossum as a code owner Aug 19, 2021
serhiy-storchaka
serhiy-storchaka reviewed Aug 20, 2021
View changes
Lib/typing.py Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 21, 2021
Merged
@Fidget-Spinner
Copy link
Contributor Author

@Fidget-Spinner Fidget-Spinner commented Aug 21, 2021

Wait don't merge yet, I need to update some things.

@Fidget-Spinner Fidget-Spinner marked this pull request as draft Aug 21, 2021
@Fidget-Spinner
Merge remote-tracking branch 'upstream/main' into name_annotated
f26b866
@Fidget-Spinner
Copy link
Contributor Author

@Fidget-Spinner Fidget-Spinner commented Aug 21, 2021 •
edited

Interestingly, Annotated[Any, 'foo'].__name__ now returns Any, because it sets origin to Any.

This behavior is quite opinionated, but is consistent with how get_type_hints treats Annotated (it strips the Annotated information and just gives the contained type). Nonetheless, I have made it return 'Annotated'.

@Fidget-Spinner
fix tests, remove news
1cebc04
@Fidget-Spinner
__name__ for Annotated is 'Annotated'
ba279d2
@Fidget-Spinner Fidget-Spinner marked this pull request as ready for review Aug 21, 2021
@Fidget-Spinner Fidget-Spinner changed the title bpo-44524: Temporarily exclude _name from typing.Annotated bpo-44524: Don't modify MRO when inheriting from typing.Annotated Aug 21, 2021
@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 25, 2021

Merge?

@Fidget-Spinner
Copy link
Contributor Author

@Fidget-Spinner Fidget-Spinner commented Aug 25, 2021

Merge?

Please do. I don't have permissions to merge this myself.

@serhiy-storchaka serhiy-storchaka merged commit 23384a1 into python:main Aug 25, 2021
11 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 25, 2021

Thanks @Fidget-Spinner for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 25, 2021

GH-27950 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Aug 25, 2021
@Fidget-Spinner @miss-islington
bpo-44524: Don't modify MRO when inheriting from typing.Annotated (py…
7e1786c 
…thonGH-27841)

(cherry picked from commit 23384a1)

Co-authored-by: Ken Jin <[email protected]>
miss-islington added a commit that referenced this issue Aug 25, 2021
@Fidget-Spinner @miss-islington
bpo-44524: Don't modify MRO when inheriting from typing.Annotated (GH…
06e9a35 
…-27841)

(cherry picked from commit 23384a1)

Co-authored-by: Ken Jin <[email protected]>
@Fidget-Spinner Fidget-Spinner deleted the name_annotated branch Aug 26, 2021
@tk0miya tk0miya mentioned this pull request Aug 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed skip news type-bugfix
Projects
None yet
Milestone
No milestone
5 participants
@Fidget-Spinner @serhiy-storchaka @miss-islington @bedevere-bot @the-knights-who-say-ni