The Wayback Machine - https://web.archive.org/web/20211027192201/https://github.com/python/cpython/pull/27926
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-37596: Make set and frozenset marshalling deterministic #27926

Merged
merged 7 commits into from Aug 25, 2021
Merged

bpo-37596: Make set and frozenset marshalling deterministic #27926

merged 7 commits into from Aug 25, 2021

Conversation

@brandtbucher
Copy link
Member

@brandtbucher brandtbucher commented Aug 24, 2021 •
edited by bedevere-bot

This PR is intended as an alternative to #27769.

https://bugs.python.org/issue37596
brandtbucher and others added 3 commits Aug 24, 2021
@brandtbucher
Serialize frozenset elements deterministically
af19777
@brandtbucher
Add regression test
ae38619
@brandtbucher
blurb add
4be57ef
@brandtbucher brandtbucher requested a review from tiran as a code owner Aug 24, 2021
@brandtbucher
Fix comment
1aff762
@brandtbucher
Cleanup
b71204e
@brandtbucher
More cleanup
597be1c
@ambv ambv mentioned this pull request Aug 24, 2021
Closed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 24, 2021

🤖 New build scheduled with the buildbot fleet by @ambv for commit 597be1c 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@brandtbucher
Copy link
Member Author

@brandtbucher brandtbucher commented Aug 24, 2021

Buildbot failure looks unrelated (it seems to have been having that issue for several days).

rhettinger
rhettinger reviewed Aug 24, 2021
View changes
Lib/test/test_marshal.py Outdated Show resolved Hide resolved
rhettinger
rhettinger reviewed Aug 24, 2021
View changes
Lib/test/test_marshal.py Outdated Show resolved Hide resolved
rhettinger
rhettinger reviewed Aug 24, 2021
View changes
Python/marshal.c Outdated Show resolved Hide resolved
rhettinger
rhettinger reviewed Aug 24, 2021
View changes
Python/marshal.c Outdated Show resolved Hide resolved
rhettinger
rhettinger approved these changes Aug 24, 2021
View changes
Python/marshal.c Outdated Show resolved Hide resolved
@brandtbucher
Address feedback from PR review
23723cb
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Aug 25, 2021

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 23723cb 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@ambv ambv merged commit 33d95c6 into python:main Aug 25, 2021
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger

@tiran tiran

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@brandtbucher @bedevere-bot @rhettinger @ambv @the-knights-who-say-ni