The Wayback Machine - https://web.archive.org/web/20210930140912/https://github.com/python/cpython/pull/27947
Skip to content

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45000: Raise SyntaxError when try to delete __debug__ #27947

Merged
merged 7 commits into from Aug 25, 2021
Merged

bpo-45000: Raise SyntaxError when try to delete __debug__ #27947

merged 7 commits into from Aug 25, 2021

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Aug 25, 2021 •
edited by miss-islington

https://bugs.python.org/issue45000

Automerge-Triggered-By: GH:pablogsal
@corona10 corona10 requested a review from markshannon as a code owner Aug 25, 2021
@corona10 corona10 changed the title bpo-45000: Make deleting __debug__ is forbidden bpo-45000: Raise SyntaxError when try to deleting __debug__ Aug 25, 2021
@corona10 corona10 requested a review from pablogsal Aug 25, 2021
@corona10
Copy link
Member Author

@corona10 corona10 commented Aug 25, 2021 

0:00:00 load avg: 3.01 Run tests sequentially
0:00:00 load avg: 3.01 [1/1] test_syntax
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1.5 sec
Tests result: SUCCESS

@corona10 corona10 changed the title bpo-45000: Raise SyntaxError when try to deleting __debug__ bpo-45000: Raise SyntaxError when try to delete __debug__ Aug 25, 2021
corona10 added 4 commits Aug 25, 2021
@corona10
bpo-45000: Raise SyntaxError when try to delete __debug__
b98961a
@corona10
bpo-45000: Add test
4ff7d1f
@corona10
bpo-45000: Update NEWS.d
e84db0b
@corona10
bpo-45000: Update whatsnews
6a18da2
@corona10
bpo-45000: nit
a7f0fef
@pablogsal
Update Misc/NEWS.d/next/Core and Builtins/2021-08-25-23-17-32.bpo-450…
f935130 
…00.XjmyLl.rst
pablogsal
pablogsal reviewed Aug 25, 2021
View changes
Doc/whatsnew/3.11.rst Outdated Show resolved Hide resolved
@pablogsal
Update Doc/whatsnew/3.11.rst
39efe6c
pablogsal
pablogsal reviewed Aug 25, 2021
View changes
Doc/whatsnew/3.11.rst
@@ -176,6 +176,8 @@ Other CPython Implementation Changes
support :class:`typing.SupportsComplex` and :class:`typing.SupportsBytes` protocols.
(Contributed by Mark Dickinson and Dong-hee Na in :issue:`24234`.)

* A :exc:`SyntaxError` (instead of a :exc:`NameError`) will be raised when deleting the :const:`__debug__` constant. (Contributed by Dong-hee Na in :issue:`45000`.)
Copy link
Member

@pablogsal pablogsal Aug 25, 2021

We should backport, so this needs to be moved to the 3.10 document

Copy link
Member

@pablogsal pablogsal Aug 25, 2021

@corona10 I think you missed this message :)

Copy link
Member Author

@corona10 corona10 Aug 25, 2021

I think you missed this message :)

@pablogsal Looks like due to auto-merge label :(

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Aug 25, 2021

@corona10: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 551da59 into python:main Aug 25, 2021
12 checks passed
corona10 added a commit to corona10/cpython that referenced this issue Aug 26, 2021
@corona10
bpo-45000: Raise SyntaxError when try to delete __debug__ (pythonGH-2…
fd94f63 
…7947)

(cherry picked from commit 551da59)
pablogsal pushed a commit that referenced this issue Aug 26, 2021
@corona10
bpo-45000: Raise SyntaxError when try to delete __debug__ (GH-27947) (G…
32c1caa 
…H-27957)

(cherry picked from commit 551da59)
@corona10 corona10 deleted the bpo-45000 branch Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@markshannon markshannon

Assignees
No one assigned
Labels
CLA signed 🤖 automerge
Projects
None yet
Milestone
No milestone
5 participants
@corona10 @miss-islington @pablogsal @the-knights-who-say-ni @bedevere-bot