The Wayback Machine - https://web.archive.org/web/20221223122946/https://github.com/python/cpython/pull/27968
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45011: Fix test_asyncio without C module _asyncio #27968

Merged
merged 3 commits into from Aug 26, 2021
Merged

bpo-45011: Fix test_asyncio without C module _asyncio #27968

merged 3 commits into from Aug 26, 2021

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Aug 26, 2021 •
edited by bedevere-bot

@serhiy-storchaka serhiy-storchaka requested review from 1st1 and asvetlov Aug 26, 2021
@mattip
Copy link
Contributor

mattip commented Aug 26, 2021

Thanks. Backported to PyPy 3.8, now tests are green. I needed to add support.gc_collect() to test_start_tls_client_reg_proto_1 and test_create_connection_memory_leak in test/test_asyncio/test_sslproto.py as well, perhaps that is not relevant for this since it targets python3.9+.

@ambv ambv merged commit 7dc505b into python:main Aug 26, 2021
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 26, 2021

Thanks @serhiy-storchaka for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2021
@serhiy-storchaka @miss-islington
bpo-45011: Fix test_asyncio without C module _asyncio (pythonGH-27968)
830a3c7 
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 7dc505b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Aug 26, 2021

GH-27969 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

bedevere-bot commented Aug 26, 2021

GH-27970 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2021
@serhiy-storchaka @miss-islington
bpo-45011: Fix test_asyncio without C module _asyncio (pythonGH-27968)
bfed843 
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 7dc505b)

Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington added a commit that referenced this pull request Aug 26, 2021
@miss-islington @serhiy-storchaka
bpo-45011: Fix test_asyncio without C module _asyncio (GH-27968)
9f814be 
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 7dc505b)

Co-authored-by: Serhiy Storchaka <[email protected]>
ambv pushed a commit that referenced this pull request Aug 26, 2021
@miss-islington @serhiy-storchaka
[3.9] bpo-45011: Fix test_asyncio without C module _asyncio (GH-27968) (
970533e 
GH-27970)

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 7dc505b)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1

@asvetlov asvetlov

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@serhiy-storchaka @mattip @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni