The Wayback Machine - https://web.archive.org/web/20221223125057/https://github.com/python/cpython/pull/28060
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45042: Now test classes decorated with requires_hashdigest are not skipped #28060

Merged
merged 6 commits into from Sep 4, 2021

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Aug 30, 2021

@sobolevn
Copy link
Member Author

sobolevn commented Aug 30, 2021

@sobolevn
Copy link
Member Author

sobolevn commented Aug 30, 2021

Both new Windows failures were hidden under @hashlib_helper.requires_hashdigest('md5'):

 ======================================================================
FAIL: test_shared_memory_basics (test.test_multiprocessing_spawn.WithProcessesTestSharedMemory)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\_test_multiprocessing.py", line 3794, in test_shared_memory_basics
    self.assertEqual(sms.size, sms2.size)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 512 != 4096

======================================================================
FAIL: test_checksum_fodder (test.test_tools.test_md5sum.MD5SumTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\cpython\cpython\lib\test\test_tools\test_md5sum.py", line 41, in test_checksum_fodder
    self.assertIn(part.encode(), out)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: b'@test_1772_tmp\xc3\xa6' not found in b'd38dae2eb1ab346a292ef6850f9e1a0d @test_1772_tmp\xe6\\md5sum.fodder\r\n'

What should I do with them? Ignore them for now and create new bug reports?

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Aug 30, 2021

I think it is safe to decorate the failed tests with

@unittest.skipIf(sys.platform == "win32", "test is broken on Windows")

We will fix them in separate issues.

@sobolevn
Copy link
Member Author

sobolevn commented Aug 30, 2021

I am not seeing any references of newly-unignored tests in Ubuntu / MacOS builds:

  1. Ubuntu: https://github.com/python/cpython/runs/3462443201
  2. MacOS: https://github.com/python/cpython/runs/3462443151

For some reason they are only executed on Windows. Is it supposed to be this way?

@serhiy-storchaka serhiy-storchaka added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section needs backport to 3.9 needs backport to 3.10 tests Tests in the Lib/test dir labels Sep 4, 2021
@bedevere-bot
Copy link

bedevere-bot commented Sep 4, 2021

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit d86ac43 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 4, 2021
@serhiy-storchaka serhiy-storchaka merged commit dd7b816 into python:main Sep 4, 2021
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 4, 2021

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 4, 2021

Sorry, @sobolevn and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker dd7b816ac87e468e2fa65ce83c2a03fe1da8503e 3.9

@bedevere-bot
Copy link

bedevere-bot commented Sep 4, 2021

GH-28168 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 4, 2021
…not skipped (pythonGH-28060)

Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit dd7b816)

Co-authored-by: Nikita Sobolev <[email protected]>
@miss-islington
Copy link
Contributor

miss-islington commented Sep 4, 2021

Thanks @sobolevn for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 4, 2021

Sorry @sobolevn and @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker dd7b816ac87e468e2fa65ce83c2a03fe1da8503e 3.9

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Sep 4, 2021
…` are not skipped (pythonGH-28060)

Co-authored-by: Serhiy Storchaka <[email protected]>.
(cherry picked from commit dd7b816)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Sep 4, 2021

GH-28169 is a backport of this pull request to the 3.9 branch.

@sobolevn
Copy link
Member Author

sobolevn commented Sep 4, 2021

Thanks, @serhiy-storchaka! It was a pleasure 🤝

miss-islington added a commit that referenced this pull request Sep 4, 2021
…not skipped (GH-28060)

Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit dd7b816)

Co-authored-by: Nikita Sobolev <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Sep 5, 2021
…` are not skipped (GH-28060) (GH-28169)

Co-authored-by: Serhiy Storchaka <[email protected]>.
(cherry picked from commit dd7b816)

Co-authored-by: Nikita Sobolev <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants