Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
bpo-45061: Detect Py_DECREF(Py_True) bug #28089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a deallocator to the bool type to detect refcount bugs in C extensions which call Py_DECREF(Py_True) or Py_DECREF(Py_False) by mistake.
|
Using os_uname_refcount_bug.patch of bpo-45061, I get the following error message: |
|
It is not possible to create a subclass of bool: |
ambv
reviewed
Aug 31, 2021
Objects/boolobject.c
Outdated
| static void _Py_NO_RETURN | ||
| bool_dealloc(PyObject* Py_UNUSED(ignore)) | ||
| { | ||
| Py_FatalError("deallocating True or False likely caused by refcount bug " |
There was a problem hiding this comment.
Suggested change
| Py_FatalError("deallocating True or False likely caused by refcount bug " | |
| Py_FatalError("deallocating True or False likely caused by a refcount bug " |
ambv
reviewed
Aug 31, 2021
Objects/object.c
Outdated
| * we accidentally decref None out of existence. | ||
| */ | ||
| Py_FatalError("deallocating None"); | ||
| Py_FatalError("deallocating None likely caused by refcount bug " |
There was a problem hiding this comment.
Suggested change
| Py_FatalError("deallocating None likely caused by refcount bug " | |
| Py_FatalError("deallocating None likely caused by a refcount bug " |
|
@ambv: Sure, I changed the error message. |
|
Merged. Thanks for the reviews! I don't think that it's worth it to backport it to 3.10, it's a new feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a deallocator to the bool type to detect refcount bugs in C
extensions which call Py_DECREF(Py_True) or Py_DECREF(Py_False) by
mistake.
https://bugs.python.org/issue45061