fix(rustc_lint): better detect when parens are necessary #88547
Merged
+104
−7
Conversation
|
(rust-highfive has picked a reviewer for you, use r? to override) |
|
|
notriddle
force-pushed the
notriddle:notriddle/is-expr-delims-necessary
branch
from
c7809a6
to
59b245e
|
LGTM, thanks! |
|
r? @davidtwco |
|
|
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 1, 2021
…necessary, r=davidtwco fix(rustc_lint): better detect when parens are necessary Fixes rust-lang#88519
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 1, 2021
…necessary, r=davidtwco fix(rustc_lint): better detect when parens are necessary Fixes rust-lang#88519
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 1, 2021
…laumeGomez Rollup of 11 pull requests Successful merges: - rust-lang#83342 (Allow writing of incomplete UTF-8 sequences to the Windows console via stdout/stderr) - rust-lang#87114 (Lint missing Abi in ast validation instead of lowering.) - rust-lang#87580 (Update Windows Argument Parsing) - rust-lang#88161 (Fix handling of +whole-archive native link modifier.) - rust-lang#88363 (Path remapping: Make behavior of diagnostics output dependent on presence of --remap-path-prefix.) - rust-lang#88490 (Display associated types of implementors) - rust-lang#88505 (Use `unwrap_unchecked` where possible) - rust-lang#88532 (Remove single use variables) - rust-lang#88543 (Improve closure dummy capture suggestion in macros.) - rust-lang#88547 (fix(rustc_lint): better detect when parens are necessary) - rust-lang#88565 (Add regression test for issue 83190) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 2, 2021
…necessary, r=davidtwco fix(rustc_lint): better detect when parens are necessary Fixes rust-lang#88519
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 2, 2021
…laumeGomez Rollup of 9 pull requests Successful merges: - rust-lang#88363 (Path remapping: Make behavior of diagnostics output dependent on presence of --remap-path-prefix.) - rust-lang#88386 (Point at unclosed delimiters as part of the primary MultiSpan) - rust-lang#88428 (expand: Treat more macro calls as statement macro calls) - rust-lang#88505 (Use `unwrap_unchecked` where possible) - rust-lang#88532 (Remove single use variables) - rust-lang#88543 (Improve closure dummy capture suggestion in macros.) - rust-lang#88547 (fix(rustc_lint): better detect when parens are necessary) - rust-lang#88560 (`fmt::Formatter::pad`: don't call chars().count() more than one time) - rust-lang#88565 (Add regression test for issue 83190) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #88519