The Wayback Machine - https://web.archive.org/web/20210902162550/https://github.com/tensorflow/tensorflow/pull/51567
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --config=rbe_lite_linux in .bazelrc #51567

Merged
merged 2 commits into from Aug 30, 2021

Conversation

@coeuvre
Copy link
Contributor

@coeuvre coeuvre commented Aug 19, 2021

Both --config=rbe_cpu_linux and --config=rbe_linux_py3 expand to --config=rbe_linux which includes link opts for avx instructions. However that won't compile Tensorflow Lite.

This PR adds --config=rbe_lite_linux which reuses most of existing flags for building Tensorflow Lite with RBE.

Context: b/195294181

@coeuvre coeuvre changed the title Add --config=tf_lite_linux in .bazelrc Add --config=rbe_lite_linux in .bazelrc Aug 19, 2021
@coeuvre coeuvre force-pushed the coeuvre:tflite-bazelrc branch from 2d1b7af to 349cf78 Aug 19, 2021
@gbaned gbaned self-assigned this Aug 19, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 19, 2021
@gbaned gbaned requested a review from mihaimaruseac Aug 19, 2021
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Can you also document these options in the comments at the beginning of the file please?

PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Aug 19, 2021
@coeuvre
Copy link
Contributor Author

@coeuvre coeuvre commented Aug 25, 2021

Added document for the option rbe_lite_linux.

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 25, 2021
@mihaimaruseac mihaimaruseac changed the title Add --config=rbe_lite_linux in .bazelrc Add --config=rbe_lite_linux in .bazelrc Aug 25, 2021
@gbaned
gbaned approved these changes Aug 27, 2021
@copybara-service copybara-service bot merged commit 5266664 into tensorflow:master Aug 30, 2021
14 checks passed
14 checks passed
@kokoro-team
Android Demo App Internal CI build successful
Details
@tensorflow-jenkins
Intel® oneDNN -- Community CI Build oneDNN CI build successful
Details
@kokoro-team
Linux GPU Internal CI build successful
Details
@kokoro-team
MacOS CPU Python3 Internal CI build successful
Details
@kokoro-team
TFLite Android Demo App Internal CI build successful
Details
@kokoro-team
TFLite CMake Internal CI build successful
Details
@kokoro-team
TFLite iOS Tests Internal CI build successful
Details
@kokoro-team
Ubuntu CPU Internal CI build successful
Details
@kokoro-team
Ubuntu Sanity Internal CI build successful
Details
@kokoro-team
Windows Bazel Internal CI build successful
Details
@kokoro-team
Windows Bazel GPU Internal CI build successful
Details
@google-cla
cla/google All necessary CLAs are signed
@copybara-service
feedback/copybara Google internal checks PASS for runs with create time 2021-08-30T15:00:20.070677496Z.
Details
@copybara-service
import/copybara Change imported to the internal review system
Details
PR Queue automation moved this from Approved by Reviewer to Merged Aug 30, 2021
@coeuvre coeuvre deleted the coeuvre:tflite-bazelrc branch Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PR Queue
  
Merged
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants