The Wayback Machine - https://web.archive.org/web/20210916151032/https://github.com/angular/components/pull/15406
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable vscode autoformat settings #15406

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 6, 2019

Disables the auto-formatting in vscode until we can format the entire codebase.

Disables the auto-formatting in vscode until we can format the entire codebase.
@ngbot
Copy link

@ngbot ngbot bot commented Mar 6, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing
    pending status "ci/circleci: api_golden_checks" is pending
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: build_release_packages" is pending
    pending status "ci/circleci: e2e_tests" is pending
    pending status "ci/circleci: lint" is pending
    pending status "ci/circleci: prerender_build" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@josephperrott josephperrott merged commit fbae483 into angular:master Mar 7, 2019
12 of 13 checks passed
12 of 13 checks passed
@ngbot[bot]
ci/angular: merge status Status "branch-manager" is pending
@angular-branch-manager[bot]
branch-manager Checked 1 branch — 7.3.x: success
Details
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
@googlebot
cla/google All necessary CLAs are signed
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 10, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants